Enhance session pool #279
Merged
Enhance session pool #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarrisChu
force-pushed
the
enhance_session_pool
branch
from
be91827
to
60525d6
Compare
|
fix sslConfig in session pool, and add a test |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #279 +/- ##
==========================================
- Coverage 61.44% 61.27% -0.17%
==========================================
Files 8 8
Lines 2329 2376 +47
==========================================
+ Hits 1431 1456 +25
- Misses 760 782 +22
Partials 138 138
☔ View full report in Codecov by Sentry. |
Aiee
reviewed
Jul 21, 2023
Nicole00
previously approved these changes
Aug 8, 2023
HarrisChu
force-pushed
the
enhance_session_pool
branch
from
ec3ca66
to
547962a
Compare
HarrisChu
force-pushed
the
enhance_session_pool
branch
from
cec1fa2
to
9eb1fa0
Compare
Aiee
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pureSession, and no any retry logic.a. connection pool, should retry in
Sessionb. session pool, should retry in
SessionPoolhold on for testing