Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zipfile #332

Merged
merged 5 commits into from
Apr 19, 2023
Merged

Zipfile #332

merged 5 commits into from
Apr 19, 2023

Conversation

OmegaPointZero
Copy link
Contributor

Add ZipFile

Description of changes in release / Impact of release:

Adds stdlib zipfile functionality to Larky, allowing us to zip/unzip traffic with Larky.

Documentation

(insert text here)

Risks of this release

n/a

Is this a breaking change?

  • Yes
  • No

If you answered Yes then describe why is it so

(insert text here if applicable)

Is there a way to disable the change?

  • Use previous release
  • Use a feature flag
  • No

Additional details go here

(insert text here if applicable)

@Iapetus999
Copy link
Contributor

I'm wondering what the utility of this is, unzipping things can have huge memory consequences. I don't think Larky is the right tool for this. I think we might have some other projects that would be better at unzipping (like SFTP proxy)

@Iapetus999
Copy link
Contributor

Also needs Jira links so I comment there why this is a Bad Idea

@OmegaPointZero
Copy link
Contributor Author

This is for a TCB project, can explain in Jira: https://verygoodsecurity.atlassian.net/browse/INT-316

@OmegaPointZero
Copy link
Contributor Author

Commented in the Jira.

@Iapetus999
Copy link
Contributor

http proxy can unzip file. ProcessZipOperationConfig

@OmegaPointZero
Copy link
Contributor Author

Do we have docs for those? I can't find anything for the FCO's that start with type.googleapis.com. We also need to be able to zip it back up again after we alias the contents of it.

@Iapetus999
Copy link
Contributor

I know OMF uses it, maybe you can copy that over to HTTP?

@OmegaPointZero
Copy link
Contributor Author

We've already tried using that operation, it doesn't work on the HTTP Proxy. CC: @alejohern

larky/src/main/resources/stdlib/zipfile.star Outdated Show resolved Hide resolved
larky/src/main/resources/stdlib/zipfile.star Outdated Show resolved Hide resolved
larky/src/main/resources/stdlib/zipfile.star Outdated Show resolved Hide resolved
larky/src/main/resources/stdlib/zipfile.star Outdated Show resolved Hide resolved
@OmegaPointZero OmegaPointZero merged commit b2394d5 into verygoodsecurity:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants