Merge pull request #14 from verygoodsecurity/override-stats-fix

Fix memory leak related to stats collection
verygoodsecurity · Aug 2, 2021 · df167d4 · df167d4
2 parents 05f6e87 + 557e8bb
commit df167d4
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/config/config_impl.go b/src/config/config_impl.go
@@ -267,7 +267,9 @@ func (this *rateLimitConfigImpl) GetLimit(
 	}
 
 	if descriptor.GetLimit() != nil {
-		rateLimitKey := domain + "." + this.descriptorToKey(descriptor)
+		//rateLimitKey := domain + "." + this.descriptorToKey(descriptor)
+		// when ip is unique for each request it generates too many stats counters and never cleans them up
+		rateLimitKey := domain + ".override"
 		rateLimitOverrideUnit := pb.RateLimitResponse_RateLimit_Unit(descriptor.GetLimit().GetUnit())
 		rateLimit = NewRateLimit(
 			descriptor.GetLimit().GetRequestsPerUnit(),