fix: replace SHA-256 with PBKDF2 for password hashing in auth template - #767
Merged
Conversation
The auth template used raw SHA-256 for password hashing with no salt and no cost factor, making stored passwords trivially reversible via rainbow tables. Password verification also used direct string comparison (===), which is vulnerable to timing attacks. Replace with PBKDF2-SHA256 (100k iterations, 16-byte random salt) using the Web Crypto API — no external dependencies needed. Passwords are now stored in "salt:hash" hex format. Verification uses constant-time byte comparison to prevent timing side-channel attacks. Addresses the real security issue behind PR #756 (Aikido review).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
db.tsto match new formatsalt:hashformatThis was the real security issue behind Aikido PR #756 (which was closed because its timing-safe comparison fix introduced an import shadowing bug). SHA-256 is unsuitable for password hashing — brute-forceable at billions/sec on commodity hardware.
Test plan
veryfront generate feature auth