fix: apply code quality findings - #740
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: def06e2b8d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (!returnPath.startsWith("/") || returnPath.includes("://")) { | ||
| returnPath = "/"; |
There was a problem hiding this comment.
Preserve valid query strings in auth return path
The new returnPath.includes("://") guard turns many legitimate protected URLs into from=/ (for example, /dashboard?next=https://docs.example.com) because it scans the entire path+query string, not just whether the return target itself is absolute. In those cases users lose their original destination after sign-in and are always sent to /, which is a functional regression for flows that include full URLs in query params.
Useful? React with 👍 / 👎.
| if (!cacheCompletedDiscovery) { | ||
| discoveredProjects.delete(key); | ||
| const current = discoveredProjects.get(key); | ||
| if (current === promise) { |
Summary
Squashes safe fixes from Copilot Autofix PRs #730, #731, #733 into a single commit.
projectUpdatedExcluded PRs
.tsextension breaks Deno type checkingisMarkdownPreviewintentionally returnstrueforundefinedfilePathCloses #730, closes #731, closes #733