Repository navigation
test: retain pre-cancelled parent reason under Bun GC - #4793
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Client bundle boundary
A server module in a client graph aborts hydration in the browser. New leaks fail CI; known leaks are tracked in |
|
@codex review |
|
Independent correctness + spec + quality review: 98/100, APPROVE, no blockers at d8f9b68. The strict identity assertion keeps the expected abort error referenced and verifies forwarding; work never starts. Mandatory pre-push format, lint, typecheck and full unit suite passed unchanged. Test-only merged Demo is prepared in veryfront/veryfront-acceptance#225 (collector review 97/100). |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Refs veryfront/veryfront-issue-inbox#2378
Bun 1.3.6 can collect an inline
AbortController.abort()reason, leavingsignal.reasonundefined (upstream defect). Keep the pre-cancelled fixture's expected error alive until the rejection assertion and verify exact identity. The no-work-started assertion remains.Validation: native GC repro lost 3 reasons in 20,000 attempts; retaining the expected reason lost 0/20,000. The patched timeout file passed 20 consecutive Bun 1.3.6 runner invocations in normal file order. Pinned Deno 2.7.7: all 34 steps passed. Testing-front-door and semantic-disposition audits passed; no globals or prototypes changed. Formatting, focused lint and typecheck passed. Mandatory pre-push verification runs unchanged.
Test-only Demo: record 20 consecutive runs again at the merge SHA and the next green main
tests (bun)run in veryfront-acceptance. No runtime release/pin needed.