-
Notifications
You must be signed in to change notification settings - Fork 0
feat(cache): add opt-in dependency snapshot store provider #4461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kwakayama
wants to merge
20
commits into
main
Choose a base branch
from
fix/shared-dependency-snapshot-store
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
79ec86d
fix(runtime): share dependency snapshot history through the distribut…
kwakayama e1c7989
fix(cache): harden the shared snapshot store per review
kwakayama 855c8cb
fix(cache): scope the automatic snapshot store and its record bounds
kwakayama eb367da
fix(cache): honor the store contract's signal, expiry, and test isola…
kwakayama c44ea65
fix(cache): make snapshot store activation host-explicit and capture …
kwakayama 321967c
fix(cache): capture reflection intrinsics and null-prototype the reco…
kwakayama 0f7797c
fix(cache): capture collection intrinsics in capability traversals
kwakayama 9d6a4f2
fix(cache): stop capability injection and harden the accessor's intri…
kwakayama d9e09bc
docs(cache): state the store's accepted residual properties
kwakayama 9261b8c
fix(cache): export snapshot factory and protect private read capabili…
kojiwakayama a050c8a
fix(deps): update sharp to patched libheif binaries
kojiwakayama e24b8d9
fix(build): synchronize proxy lockfile with sharp patch
kojiwakayama c392197
fix(cache): protect captured revision capabilities and clarify limits
kojiwakayama 4a84987
fix(cache): use reserved keys for snapshot revision operations
kojiwakayama cabeb13
fix(cache): require own snapshot record fields
kojiwakayama a1f53d5
fix(cache): keep private backends out of promise species
kojiwakayama dda6f59
fix(cache): require exact snapshot retention deadlines
kojiwakayama 606eab3
Resolve main conflict with strict Sharp cache identity
kojiwakayama e2edfe3
fix(cache): retry identical snapshot publication races
kojiwakayama 2d3a7ce
fix(cache): reject expired snapshot publication retries
kojiwakayama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When project code installs a callable
Object.prototype.thenbefore a store operation, this nativePromise.resolve(state.backend)performs thenable assimilation and invokes the inherited hook with the cached API or Redis backend asthis; initialization'sreturn bhas the same behavior. This is separate from the fixed species path and exposes the opaque backend and its credential-bearing client, while the hook can also resolvenullto make storage appear unavailable. Ensure promises carry only an opaque, non-thenable token rather than the raw backend.AGENTS.md reference: AGENTS.md:L110-L112
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed at a1f53d5 with a deterministic cached-backend reproducer. After successful initialization, installing a callable Object.prototype.then exposes the exact synthetic API backend as the hook receiver on the next accessor call (1 exposure, expected 0), and the hook can replace the resolved result with null. Moving finally cleanup does not address native thenable assimilation. This requires an asynchronous capability contract that carries an opaque, non-thenable token instead of the raw backend, including the initialization path. I am leaving this finding open and keeping the PR draft alongside the atomic-publication blocker. The current Promise path is not ready to satisfy the claimed shared-realm private-storage contract.