Skip to content

release: prepare v0.1.1252 RC for staging verification - #4012

Merged
kwakayama merged 1 commit into
mainfrom
release/v0.1.1252-rc
Aug 23, 2026
Merged

release: prepare v0.1.1252 RC for staging verification#4012
kwakayama merged 1 commit into
mainfrom
release/v0.1.1252-rc

Conversation

@kwakayama

Copy link
Copy Markdown
Contributor

Summary

  • open the 0.1.1252-rc prerelease line so main publishes numbered RCs again
  • keep the runtime version constant and the generated hydration bundle in sync

Why this is needed now

deno.json reads a clean 0.1.1251, and 0.1.1251 is already published to npm
(npm view veryfront@0.1.1251 gitHead0f38b23eb7). The release job reads deno.json, sees no
version change, and correctly no-ops.

src/utils/version.test.ts asserts VERSION === deno.json.version but not that it increased,
so CI stays fully green the whole time. The symptom is silent: merged, green, and shipped nowhere.

21 commits currently sit above the published version and have reached no environment, including:

Verification

  • deno task generate:manifests:check
  • deno task fmt:check
  • deno test -A src/config/cicd-stable-release.test.ts src/utils/version.test.ts
  • the regenerated hydration bundle differs in exactly one segment — its embedded version string
    (var VERSION = "0.1.1251""0.1.1252-rc"); diff is 3 files, 1 line each

After this

RC publishes → server / job-runner / sandbox staging deploys → strict staging Remote E2E Health →
stable 0.1.1252 → production promotion. Production currently runs 0.1.1248.

@github-actions

Copy link
Copy Markdown

📦 Client bundle boundary

Entrypoint Modules Source size Server leaks
src/index.client.ts 327 1961 KiB ✅ 0

A server module in a client graph aborts hydration in the browser. New leaks fail CI; known leaks are tracked in scripts/lint/client-bundle-baseline.json to burn down.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@kwakayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6c915733-3524-4e34-bf5d-dd0050312829

📥 Commits

Reviewing files that changed from the base of the PR and between 9bac878 and a4804e5.

⛔ Files ignored due to path filters (1)
  • src/html/hydration-script-builder/hydration-runtime.generated.ts is excluded by !**/*.generated.*
📒 Files selected for processing (2)
  • deno.json
  • src/utils/version-constant.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kwakayama

Copy link
Copy Markdown
Contributor Author

Reviewed. The bump itself is clean. The three red jobs are not this PR's fault, but they are worth naming because they will now be red on every release PR.

The bump is complete and matches the documented procedure

scripts/release.ts bumps deno.json, then rewrites cli/commands/init/config-generator.ts, src/core/utils/constants/cdn.ts, src/utils/version.ts and src/utils/version-constant.ts, then runs deno task generate for hydration-runtime.generated.ts (the reason is spelled out at scripts/release.ts:267). Of those, only version-constant.ts holds a literal: config-generator.ts and version.ts derive from VERSION, and cdn.ts does not exist. So three files is the whole set, and git grep 0.1.1251 over tracked files returns nothing. The file list is identical to #3965 and #3933.

Nothing rides along: the diff is 3 files, 1 line each, all of it the version string.

Why the runtime critical flow jobs fail

tests (runtime critical flow: deno | node | bun) fail with:

npm error code ETARGET
npm error notarget No matching version found for @veryfront/ext-bundler-esbuild@0.1.1252-rc.

The gate packs the local CLI at the new version, runs veryfront init, and installs the result. cli/commands/init/config-generator.ts:69 pins every first-party extension and veryfront itself to `^${VERSION}`, so the scaffold asks npm for 0.1.1252-rc of packages that only exist after the release job publishes them. That job runs after this merges.

So the gate is structurally unsatisfiable on any version-bump PR. It is green on main only because main sits at 0.1.1251, which is published.

This is new, not a regression here. The gate arrived with 9d6cdefb86 (#3977) on 2026-08-22, after the last RC. #3965's check list has no such job, which is why this is the first release PR to show it.

None of the three is a required check (ci (format), ci (lint), ci (typecheck), tests (unit), tests (integration), coverage gate, tests (rsc browser e2e), tests (binary e2e), Analyze are), and all nine required checks pass here. mergeStateStatus is UNSTABLE rather than BLOCKED for exactly that reason. So this can land.

The part worth fixing separately: left alone, three jobs go red on every RC from now on, and a gate that is always red on a known class of PR stops being read on the ones where it matters. The fix belongs in the flow script, resolving first-party extensions from the packed local tarballs rather than from npm, or skipping the install leg when the version under test is unpublished. Worth its own issue rather than holding this RC.

@kojiwakayama

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: a4804e5b9a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Merged via the queue into main with commit 09c79bd Aug 23, 2026
42 of 45 checks passed
@kwakayama
kwakayama deleted the release/v0.1.1252-rc branch August 23, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants