Repository navigation
fix(transforms)!: run the browser server-exports strip before compile #3855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
b1d545b
refactor(transforms): run the browser server-exports strip before com…
kojiwakayama 53714ad
fix(transforms): keep leading comments of statements the strip removes
kojiwakayama 30c64ee
fix(transforms): keep comments that trail the last surviving statement
kojiwakayama 0e476a8
fix(transforms): leave unrelated unused imports as authored
kojiwakayama 7c1028a
docs(transforms): note the splitter caller in the ordering dependency
kojiwakayama 8714b73
fix(transforms): delete hook-owned imports on every source dialect
kojiwakayama d6e744c
fix(transforms): never prune an exported import-equals
kojiwakayama b0f7653
test(transforms): pin the unrelated unused import in development
kojiwakayama e52fe75
fix(transforms): classify JSX references in the server-exports strip
kojiwakayama afc3eb7
fix(repo): remove the stray node_modules symlink committed by mistake
kojiwakayama 9df87a2
fix(transforms): classify every reference-walker node type
kojiwakayama 8db5dbc
test(transforms): pin every classification cell with a mutation-kille…
kojiwakayama 89d59a5
fix(transforms): test every compiler predicate against the compiler
kojiwakayama 30f34a8
test(transforms): let the compiler settle engine identifier-table drift
kojiwakayama c4e4fd7
Prevent escaped hook exports from reaching browser bundles
kojiwakayama 51b31a5
Merge origin/main into strip-before-compile work
kojiwakayama c53015a
Refresh API reference after main merge
kojiwakayama e41b944
Drop unrelated API reference churn
kojiwakayama 55cd797
fix(transforms): decide the strip gate from the grammar, not from spe…
kwakayama 191234f
test(transforms): ask the artifact which names the module exports
kwakayama 1f1d0c4
Merge origin/main into strip-before-compile work
kwakayama 2262c26
fix(transforms): reject import-equals hook bindings before compile
kojiwakayama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1,268 changes: 1,083 additions & 185 deletions
1,268
src/transforms/pipeline/stages/browser-server-exports-strip.test.ts
Large diffs are not rendered by default.
Oops, something went wrong.
561 changes: 357 additions & 204 deletions
561
src/transforms/pipeline/stages/browser-server-exports-strip.ts
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.