Skip to content

test(agent): lock multi-step Gemini signature replay - #3821

Merged
kojiwakayama merged 1 commit into
mainfrom
test/issue-549-multistep-provider-metadata
Aug 17, 2026
Merged

kojiwakayama merged 1 commit into
mainfrom
test/issue-549-multistep-provider-metadata

Conversation

@kojiwakayama

Copy link
Copy Markdown
Contributor

Summary

Why

CodeRabbit suggested consuming replay metadata after one request. Gemini requires the opposite within a sequential function-calling turn. Google documents request 3 as the full prior history and explicitly requires signatures for all function calls in the loop:

https://ai.google.dev/gemini-api/docs/generate-content/thought-signatures#sequential_function_calling_example

Consume-once behavior would remove signature A from request 3 and restore the Gemini 3 validation failure. This regression locks the required protocol behavior. It changes tests only.

Verification

deno test --preload=src/testing/preload.ts --no-check --allow-all src/agent/runtime/provider-metadata-continuation.test.ts

Result: 5 steps passed, 0 failed.

  • deno fmt
  • git diff --check

Follow-up to #3820 and veryfront/veryfront-issue-inbox#549.

@github-actions

Copy link
Copy Markdown

📦 Client bundle boundary

Entrypoint Modules Source size Server leaks
src/index.client.ts 325 1937 KiB ✅ 0

A server module in a client graph aborts hydration in the browser. New leaks fail CI; known leaks are tracked in scripts/lint/client-bundle-baseline.json to burn down.

@kojiwakayama

Copy link
Copy Markdown
Contributor Author

@codex review exact head a0ad6304dc92a1e5df7cd3c92e2760b63f25f6ac. This is a test-only protocol regression following the late #3820 review.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@kojiwakayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b97b0c27-f189-44dd-954a-0a914ae66870

📥 Commits

Reviewing files that changed from the base of the PR and between e297edb and a0ad630.

📒 Files selected for processing (1)
  • src/agent/runtime/provider-metadata-continuation.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kojiwakayama

Copy link
Copy Markdown
Contributor Author

@codex review exact head a0ad6304daf540cfcd068930ff5e3b1f7fee4478. Correction: this is the exact pushed head.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: a0ad6304da

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kojiwakayama
kojiwakayama added this pull request to the merge queue Aug 17, 2026
Merged via the queue into main with commit f576657 Aug 17, 2026
34 checks passed
@kojiwakayama
kojiwakayama deleted the test/issue-549-multistep-provider-metadata branch August 17, 2026 13:36
This was referenced Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant