chore(security): ignore test fixtures and stories in secret scanning - #3814
Conversation
📦 Client bundle boundary
A server module in a client graph aborts hydration in the browser. New leaks fail CI; known leaks are tracked in |
|
Warning Review limit reached
Next review available in: 23 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71c43a0a91
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
71c43a0 to
ac81708
Compare
|
Exact-head review requested for @codex review |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
commit='ac81708f38f96cee8117a2a4f2519c7a5b6c19f6'
git rev-parse --verify "${commit}^{commit}"
git show --no-ext-diff --format=fuller --stat "$commit"
printf '\n--- changed files ---\n'
git diff-tree --no-commit-id --name-status -r "$commit"
printf '\n--- outlines ---\n'
for file in .github/secret_scanning.yml deno.json scripts/security/secret-scanning-config.test.ts; do
if [ -f "$file" ]; then
printf '\n### %s\n' "$file"
ast-grep outline "$file" --items all 2>/dev/null || cat -n "$file"
fi
done
printf '\n--- exact diff ---\n'
git show --no-ext-diff --format= "$commit" -- \
.github/secret_scanning.yml \
deno.json \
scripts/security/secret-scanning-config.test.tsLength of output: 9180 🏁 Script executed: #!/bin/bash
set -euo pipefail
commit='ac81708f38f96cee8117a2a4f2519c7a5b6c19f6'
printf '%s\n' '--- fixture file metadata ---'
for file in src/utils/logger/logger.test.ts storybook/stories/ui/Input.stories.tsx; do
if [ -f "$file" ]; then
printf '\n### %s\n' "$file"
wc -l "$file"
ast-grep outline "$file" --items all 2>/dev/null || true
else
printf 'MISSING: %s\n' "$file"
fi
done
printf '%s\n' '--- detector-shaped fixture contexts ---'
rg -n -i -C 3 \
'(secret|token|api[_-]?key|password|credential|authorization|bearer|postgres(?:ql)?://|vf_(?:live|test)_)' \
src/utils/logger/logger.test.ts storybook/stories/ui/Input.stories.tsx || true
printf '%s\n' '--- secret-scanning configuration references ---'
rg -n -i -C 3 \
'(secret_scanning\.yml|paths-ignore|secret[ _-]?scann)' \
.github deno.json scripts README.md 2>/dev/null || true
printf '%s\n' '--- changed-file whitespace validation ---'
git diff --check "${commit}^" "$commit"
printf '%s\n' '--- exact parent diff names and status ---'
git diff --name-status "${commit}^" "$commit"Length of output: 25644
I found no actionable issues. The allowlist contains only the two specified files. The contract test enforces the exact list. I did not execute the Deno verification commands in this review environment.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac81708f38
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Exact-head follow-up
@codex review |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
commit='f68a3cefa'
printf '%s\n' '--- resolve exact commit ---'
git rev-parse --verify "${commit}^{commit}"
full_commit="$(git rev-parse "${commit}^{commit}")"
parent_commit="$(git rev-parse "${full_commit}^")"
printf 'commit=%s\nparent=%s\n' "$full_commit" "$parent_commit"
printf '%s\n' '--- changed files ---'
git diff-tree --no-commit-id --name-status -r "$full_commit"
printf '%s\n' '--- exact diff ---'
git diff --no-ext-diff "$parent_commit" "$full_commit" -- \
deno.json \
.github \
scripts/security/secret-scanning-config.test.ts
printf '%s\n' '--- task definitions and CI references ---'
rg -n -C 4 \
'"lint:secret-scanning-config"|"lint:ci"|secret-scanning-config\.test\.ts|deno task lint:ci|deno task lint:secret-scanning-config' \
deno.json .github scripts/security 2>/dev/null || true
printf '%s\n' '--- relevant file contents ---'
for file in deno.json scripts/security/secret-scanning-config.test.ts; do
if [ -f "$file" ]; then
printf '\n### %s\n' "$file"
cat -n "$file"
fi
done
printf '%s\n' '--- whitespace validation ---'
git diff --check "$parent_commit" "$full_commit"Length of output: 71744
I found no actionable issues.
I did not execute Deno commands in this review environment. If you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit! You are interacting with an AI system. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Summary
src/utils/logger/logger.test.tsandstorybook/stories/ui/Input.stories.tsx, the two files with recurring detector-shaped false positivesRED / GREEN
RED: the new config contract reported the repository-wide
**/*.test.tsand Storybook directory globs instead of the two expected fixture files.GREEN: the exact allowlist passes, and the test is included in
deno task test:scripts.Verification
deno test --config=scripts/test.deno.json --no-check --allow-read scripts/security/secret-scanning-config.test.tsdeno task typecheckdeno task lint:cideno fmt --check .github/secret_scanning.yml deno.json scripts/security/secret-scanning-config.test.tsgit diff --check