-
Notifications
You must be signed in to change notification settings - Fork 0
feat(config): support server external packages #3764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2758edb
feat(config): support server external packages
kojiwakayama d45524e
fix(cache): isolate SSR server externals
kojiwakayama a0bf388
fix(transforms): preserve MDX server externals
kojiwakayama 5506f8d
test(transforms): use literal external fixtures
kojiwakayama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| import { | ||
| primordialArrayPush, | ||
| primordialArraySort, | ||
| } from "#veryfront/platform/compat/primordials/array.ts"; | ||
|
|
||
| export const MAX_SERVER_EXTERNAL_PACKAGE_COUNT = 128; | ||
| export const MAX_SERVER_EXTERNAL_PACKAGE_NAME_LENGTH = 214; | ||
|
|
||
| const ObjectFreeze = Object.freeze; | ||
| const RegExpExec = RegExp.prototype.exec; | ||
| const ReflectApply = Reflect.apply; | ||
| const SetAdd = Set.prototype.add; | ||
| const SetHas = Set.prototype.has; | ||
| const SERVER_EXTERNAL_PACKAGE_PATTERN = /^(?:@[a-z0-9][a-z0-9._-]*\/)?[a-z0-9][a-z0-9._-]*$/; | ||
|
|
||
| /** Return whether a value names one bare npm package root. */ | ||
| export function isValidServerExternalPackageName(value: string): boolean { | ||
| return value.length <= MAX_SERVER_EXTERNAL_PACKAGE_NAME_LENGTH && | ||
| ReflectApply(RegExpExec, SERVER_EXTERNAL_PACKAGE_PATTERN, [value]) !== null; | ||
| } | ||
|
|
||
| /** Return whether every configured package name occurs exactly once. */ | ||
| export function hasUniqueServerExternalPackages(values: readonly string[]): boolean { | ||
| const seen = new Set<string>(); | ||
| for (let index = 0; index < values.length; index++) { | ||
| const value = values[index]!; | ||
| if (ReflectApply(SetHas, seen, [value]) as boolean) return false; | ||
| ReflectApply(SetAdd, seen, [value]); | ||
| } | ||
| return true; | ||
| } | ||
|
|
||
| /** Capture an immutable, order-independent package list for one transform graph. */ | ||
| export function canonicalizeServerExternalPackages( | ||
| values: readonly string[] | undefined, | ||
| ): readonly string[] | undefined { | ||
| if (!values || values.length === 0) return undefined; | ||
|
|
||
| const canonical: string[] = []; | ||
| const seen = new Set<string>(); | ||
| for (let index = 0; index < values.length; index++) { | ||
| const value = values[index]!; | ||
| if (ReflectApply(SetHas, seen, [value]) as boolean) continue; | ||
| ReflectApply(SetAdd, seen, [value]); | ||
| primordialArrayPush(canonical, value); | ||
| } | ||
| primordialArraySort(canonical, (left, right) => left < right ? -1 : left > right ? 1 : 0); | ||
| return ObjectFreeze(canonical); | ||
| } | ||
|
|
||
| /** Build a stable framed identity for cache keys whose output depends on this list. */ | ||
| export function buildServerExternalPackagesIdentity( | ||
| values: readonly string[] | undefined, | ||
| ): string | undefined { | ||
| const canonical = canonicalizeServerExternalPackages(values); | ||
| if (!canonical) return undefined; | ||
|
|
||
| let identity = ""; | ||
| for (let index = 0; index < canonical.length; index++) { | ||
| const value = canonical[index]!; | ||
| identity += `${value.length}:${value};`; | ||
| } | ||
| return identity; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.