docs(getting-started): warn that the published base tsconfig disables emit - #3762
Conversation
… emit The add-to-existing-project page leads with extending veryfront/tsconfig.json, which ships noEmit: true. A host project whose build emits with tsc keeps exiting 0 after that swap but silently stops writing its outDir - exactly the 'your existing build still works' promise the page makes. Reproduced against published v0.1.1239. Steer emitting projects to the manual three-option route (or an explicit noEmit: false), and extend the verify step to check output freshness, not just the exit code. Regression: guide-code-examples pins noEmit: true in build-npm-dnt.ts to the page's warning; the page contract now requires the noEmit snippet.
📦 Client bundle boundary
A server module in a client graph aborts hydration in the browser. New leaks fail CI; known leaks are tracked in |
|
Warning Review limit reached
Next review available in: 32 minutes Limit details: You’ve used all 3 included reviews currently available under your plan. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan includes up to 3 reviews per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe existing-project guide now documents that Veryfront’s base TypeScript configuration sets ChangesTypeScript emission guidance
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized documentation and test update is merge-ready after normal checks; no actionable merge-blocking risk remains. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56f06a7910
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Problem
DX dogfood of the published
add-to-existing-projectpage against veryfront@0.1.1239 found a High-severity doc bug: the page leads with{ "extends": "veryfront/tsconfig.json", "include": ["src", "app"] }but the shipped base config sets
"noEmit": true. A host project whose build emits withtsckeeps exiting 0 after that swap while silently writing nothing — itsdist/goes stale with no warning. That directly contradicts the page's own promise ("Your existing scripts are untouched. Confirm the build you had before still runs").Repro (published package): plain TS project building
tsc -p → dist/; follow the page; edit a source file;npm run buildexits 0;node dist/index.jsstill runs the old code.Fix
"noEmit": false"in the build config).Regression coverage
guide-code-examples.test.ts: new test pinsnoEmit: trueinbuild-npm-dnt.ts(the artifact that generates the published tsconfig) to the page carrying the warning — written first, failed for the right reason.guide-contracts.test.ts: page contract now requires the"noEmit": truesnippet.Verified:
deno test tests/docs/56/56,validate-public-docs.tsclean, and the manual-options route empirically re-verified in a sandbox (emit restored while Veryfront serves).Summary by CodeRabbit
Documentation
Tests