fix(build): validate options and expose cause diagnostics - #3715
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe build CLI now rejects unknown options with suggestions. Build-error handling traverses nested causes, redacts filesystem paths, limits stack output, and guides non-verbose users to ChangesBuild CLI validation and diagnostics
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to This PR makes localized build validation and error-diagnostics improvements, with focused and broader checks reported as passing; no actionable merge-blocking risk remains beyond normal review. Sequence Diagram(s)sequenceDiagram
participant buildCommand
participant handleBuildError
participant CauseChain as Error.cause chain
participant terminal
buildCommand->>handleBuildError: rejected build error
handleBuildError->>CauseChain: traverse nested causes
CauseChain-->>handleBuildError: deepest error
handleBuildError->>terminal: sanitized stack or verbose hint
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
📦 Client bundle boundary
A server module in a client graph aborts hydration in the browser. New leaks fail CI; known leaks are tracked in |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e7aa5a6e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Description
veryfront buildoptions and suggest the closest documented option.--verbose.The behavior changes were developed red-green: focused tests failed against the previous behavior, then passed after the implementation changes.
Related Issue(s)
Fixes veryfront/veryfront-issue-inbox#457
Fixes veryfront/veryfront-issue-inbox#458
Type of Change
Checklist
Verification
deno fmt --checkon touched filesdeno linton touched filesdeno check cli/shared/args.ts cli/commands/build/error-handler.ts cli/commands/build/handler.ts--jsoninvocations return exit code 2 for an unknown build optionSummary by CodeRabbit
Bug Fixes
Tests