Skip to content

test(agent-runs): stop a success-path assertion racing a 10ms deadline #3710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kojiwakayama merged 1 commit into from
Aug 14, 2026
Merged

test(agent-runs): stop a success-path assertion racing a 10ms deadline #3710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/agent/runtime/project-files-client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1662,8 +1662,14 @@ Deno.test("successful strict project file calls dispose cancellation listeners a
const observedSignals: AbortSignal[] = [];
const client = createStrictRuntimeProjectFilesClient({
apiUrl: baseOptions.apiUrl,
operationTimeoutMs: 10,
timeoutMs: 10,
// Deadlines only need to be larger than this call, which resolves from a
// stub. A 10ms budget made a success-path assertion depend on wall clock:
// under a loaded parallel run the deadline can elapse before the call
// settles, the timeout path runs, and the listener counts below stop being
// 1/1. Nothing here tests timeout behaviour -- the tests that do set their
// own short deadlines deliberately.
operationTimeoutMs: 30_000,
timeoutMs: 30_000,
fetch: (_url, init) => {
observedSignals.push(init.signal as AbortSignal);
return Promise.resolve(
Expand Down