docs: use verified Node container recipe - #3686
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe self-hosting guide now uses a Node.js 22 Docker workflow with locked npm dependencies. Its coverage test verifies the Node.js commands and rejects the previous Deno image. ChangesSelf-hosting Docker workflow
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to This documentation and contract-test update introduces no identified current correctness or production risk, so it is merge-ready after normal checks. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ba2b0b0a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| EXPOSE 3000 | ||
| CMD ["deno", "task", "start"] | ||
| CMD ["npm", "start"] |
There was a problem hiding this comment.
Run the server as the container's signal-receiving process
When an orchestrator stops or replaces this container, Docker sends SIGTERM to PID 1, which here is npm rather than Veryfront. npm start launches the package script as a child and does not forward SIGTERM, so the handler in cli/commands/serve/command.ts never drains tracked requests or flushes telemetry before the container exits. Use an entrypoint that execs the actual server process, or explicitly forwards and reaps signals, so this production recipe shuts down cleanly.
AGENTS.md reference: AGENTS.md:L57-L57
Useful? React with 👍 / 👎.
Summary
npm ciThe previous Dockerfile excluded
node_modulesbut did not install dependencies, sodeno task buildfailed withveryfront: command not found. The replacement was verified from a freshnpm create veryfront@latestproject using publicveryfront@0.1.1233, then built and served in Docker with an HTTP 200 response.Verification
deno test --preload=src/testing/preload.ts --no-check --allow-all tests/docs/guide-content.test.ts tests/docs/guide-contracts.test.ts tests/docs/guide-code-examples.test.tsdeno task docs:validatedeno fmt --check docs/guides/self-hosting.md tests/docs/guide-code-examples.test.tsgit diff --checkdocker build -t veryfront-public-smoke-01233 .Summary by CodeRabbit