Skip to content

fix(cli): use public config exports for deploy - #3684

Merged
kojiwakayama merged 1 commit into
mainfrom
fix/cli-config-public-boundary
Aug 13, 2026
Merged

fix(cli): use public config exports for deploy#3684
kojiwakayama merged 1 commit into
mainfrom
fix/cli-config-public-boundary

Conversation

@kojiwakayama

@kojiwakayama kojiwakayama commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • expose hosted config compatibility helpers through veryfront/config
  • use the public config boundary from the deploy helper
  • add a focused public-export test

This fixes the CLI boundary regression detected by deno task verify:quick.

Verification

  • deno test --preload=src/testing/preload.ts --no-check --allow-all src/config/index.test.ts cli/shared/deployment/deploy-project.test.ts
  • deno task lint:cli-boundary
  • deno check cli/shared/deployment/deploy-project.ts src/config/index.ts
  • deno task verify:quick

Summary by CodeRabbit

  • New Features

    • Added public configuration helpers for detecting and formatting hosted configuration incompatibilities.
    • Exposed hosted configuration incompatibility details for broader configuration workflows.
  • Bug Fixes

    • Improved deployment configuration compatibility by using the public configuration interface.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b67d7afd-5785-4701-bf8d-fcfd87a2854a

📥 Commits

Reviewing files that changed from the base of the PR and between 3651770 and 35dd3b0.

📒 Files selected for processing (3)
  • cli/shared/deployment/deploy-project.ts
  • src/config/index.test.ts
  • src/config/index.ts

📝 Walkthrough

Walkthrough

The public veryfront/config module now exports hosted configuration compatibility helpers and its type. Deployment code imports these APIs from the public module. Tests verify the exports.

Changes

Configuration API integration

Layer / File(s) Summary
Public config exports and deployment adoption
src/config/index.ts, src/config/index.test.ts, cli/shared/deployment/deploy-project.ts
The config module exports hosted compatibility helpers and HostedConfigIncompatibility. Tests verify the public exports. Deployment imports configuration symbols from veryfront/config.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Mergeability Score: ⚪ Minimal · up to 35dd3

This localized change routes deployment through the public configuration exports and adds focused coverage; no actionable merge-blocking risk remains after the stated checks.

Possibly related PRs

Suggested reviewers: kwakayama

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating the CLI deploy code to use public configuration exports.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cli-config-public-boundary

Comment @coderabbitai help to get the list of available commands.

@kojiwakayama
kojiwakayama added this pull request to the merge queue Aug 13, 2026
Merged via the queue into main with commit b67513b Aug 13, 2026
33 checks passed
@kojiwakayama
kojiwakayama deleted the fix/cli-config-public-boundary branch August 13, 2026 20:06
@kojiwakayama kojiwakayama mentioned this pull request Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant