-
Notifications
You must be signed in to change notification settings - Fork 0
chore: replace veryfront.me dev hostname with localhost #3660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -338,14 +338,14 @@ export function devCommand(options: DevOptions): Promise<DevCommandResult> { | |
| }; | ||
| } | ||
|
|
||
| const serverUrl = `http://veryfront.me:${boundPort}`; | ||
| const serverUrl = `http://localhost:${boundPort}`; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
On systems where Useful? React with 👍 / 👎. |
||
| const elapsed = Date.now() - startTime; | ||
|
|
||
| console.log(); | ||
| console.log(` ✓ Ready in ${formatDuration(elapsed)}`); | ||
| console.log(` ${brand(serverUrl)}`); | ||
| if (mcpServer && isVerbose()) { | ||
| console.log(` ${dim("MCP")} ${brand(`http://veryfront.me:${mcpPort}/mcp`)}`); | ||
| console.log(` ${dim("MCP")} ${brand(`http://localhost:${mcpPort}/mcp`)}`); | ||
| } | ||
| if (isTTY()) { | ||
| console.log(devShortcuts()); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ export const mcpHelp: CommandHelp = { | |
| "The CLI MCP server is development-only. Production start does not expose vf_* tools.", | ||
| "", | ||
| "Claude Code setup (~/.claude.json):", | ||
| ` "mcpServers": { "veryfront": { "url": "http://veryfront.me:${DEFAULT_DEV_MCP_PORT}/mcp" } }`, | ||
| ` "mcpServers": { "veryfront": { "url": "http://localhost:${DEFAULT_DEV_MCP_PORT}/mcp" } }`, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Point users to the printed MCP URL. The fixed Based on learnings: 🤖 Prompt for AI AgentsSource: Learnings |
||
| "", | ||
| "Available tools:", | ||
| " • vf_list_local_projects - Discover projects on filesystem", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -109,7 +109,7 @@ export const vfGetDebugContext: MCPTool<GetDebugContextInput, DebugContextResult | |
| withSpan( | ||
| "cli.mcp.tool.vf_get_debug_context", | ||
| async () => { | ||
| const host = input.project ? `${input.project}.veryfront.me` : "veryfront.me"; | ||
| const host = input.project ? `${input.project}.localhost` : "localhost"; | ||
| const url = `http://${host}:${input.port}/_vf_debug/context`; | ||
|
Comment on lines
+112
to
113
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When Useful? React with 👍 / 👎. |
||
|
|
||
| try { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Use the correct MCP port in the readiness example.
The example pairs
http://localhost:3000withhttp://localhost:3001/mcp. The CLI contract uses the actual development-server port plusDEV_MCP_PORT_OFFSET, so the default MCP URL ishttp://localhost:3002/mcp. An agent that copies this example cannot connect.Based on learnings, the MCP port derives from the actual bound port plus
DEV_MCP_PORT_OFFSET. The supplied documentation also uses port 3002 for an app on port 3000.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Learnings