release: start v0.1.1230 rc builds - #3622
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe release version changes to ChangesRC release version preparation
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f08c84efb0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@deno.json`:
- Line 543: Add scripts/ci/prepare-rc-build.test.ts to the existing direct
scripts-test command in .github/workflows/cicd.yml, or wire the narrowed
test:scripts task into CI, ensuring the release-preparation test actually runs
during CI without depending on the failing broader task.
In `@src/security/repository-hardening.test.ts`:
- Around line 95-101: Update the prerelease assertions in repository-hardening
tests to store the preparation command index from the prerelease job block,
assert it is non-negative, then verify it precedes the build:npm command. Do not
rely on the global workflow assertion alone.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 256ef58e-76e6-4aa8-bf67-524cf02a8dd0
📒 Files selected for processing (5)
.github/workflows/cicd.ymldeno.jsonscripts/ci/prepare-rc-build.test.tsscripts/ci/prepare-rc-build.tssrc/security/repository-hardening.test.ts
| assert(workflow.includes("deno run -A scripts/ci/prepare-rc-build.ts")); | ||
|
|
||
| const prerelease = jobBlock(workflow, "prerelease"); | ||
| assert( | ||
| prerelease.indexOf("deno run -A scripts/ci/prepare-rc-build.ts") < | ||
| prerelease.indexOf("deno task build:npm"), | ||
| ); |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Require preparation in the prerelease job.
The global assertion at Line 95 permits the command in a different job. If prerelease does not contain the command, its index is -1, and the comparison at Lines 99-100 still passes. Store the prerelease command index and assert that it is non-negative before comparing it with build:npm.
Proposed fix
- assert(workflow.includes("deno run -A scripts/ci/prepare-rc-build.ts"));
-
const prerelease = jobBlock(workflow, "prerelease");
+ const prepareIndex = prerelease.indexOf(
+ "deno run -A scripts/ci/prepare-rc-build.ts",
+ );
+ assert(prepareIndex >= 0, "expected prerelease to prepare the RC version");
assert(
- prerelease.indexOf("deno run -A scripts/ci/prepare-rc-build.ts") <
+ prepareIndex <
prerelease.indexOf("deno task build:npm"),
);📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| assert(workflow.includes("deno run -A scripts/ci/prepare-rc-build.ts")); | |
| const prerelease = jobBlock(workflow, "prerelease"); | |
| assert( | |
| prerelease.indexOf("deno run -A scripts/ci/prepare-rc-build.ts") < | |
| prerelease.indexOf("deno task build:npm"), | |
| ); | |
| const prerelease = jobBlock(workflow, "prerelease"); | |
| const prepareIndex = prerelease.indexOf( | |
| "deno run -A scripts/ci/prepare-rc-build.ts", | |
| ); | |
| assert(prepareIndex >= 0, "expected prerelease to prepare the RC version"); | |
| assert( | |
| prepareIndex < | |
| prerelease.indexOf("deno task build:npm"), | |
| ); |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/security/repository-hardening.test.ts` around lines 95 - 101, Update the
prerelease assertions in repository-hardening tests to store the preparation
command index from the prerelease job block, assert it is non-negative, then
verify it precedes the build:npm command. Do not rely on the global workflow
assertion alone.
1 participant
Summary
0.1.1229to0.1.1230-rcWhy
The existing prerelease workflow publishes every successful
mainbuild whendeno.jsoncontains a prerelease version. With this base version, CI publishes versions such as0.1.1230-rc.<run_number>to npm under thercdist-tag without changing the workflow.Stable publication remains explicit: changing the version to
0.1.1230will publish that release underlatest.Validation
deno task generate:manifests:checkwith CI-pinned Deno 2.7.7deno fmt --checkfor all changed files--no-verifySummary by CodeRabbit
Chores
0.1.1230-rc.Bug Fixes