Skip to content

test(agent): cover inherited invoke tools #3595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwakayama merged 3 commits into from
Aug 11, 2026
Merged

test(agent): cover inherited invoke tools #3595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47616a5
test(agent): cover inherited invoke tools
kwakayama Aug 11, 2026
6b6e6da
test(agent): fix generic child context assertion
kwakayama Aug 11, 2026
97c5478
test(agent): run invoke inheritance across runtimes
kwakayama Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 96 additions & 12 deletions src/agent/hosted/default-invoke-agent-tool.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import "#veryfront/schemas/_test-setup.ts";
import { assertEquals, assertRejects, assertStringIncludes } from "#veryfront/testing/assert.ts";
import { describe, it } from "#veryfront/testing/bdd.ts";
import type { CreateSandboxBashTool } from "#veryfront/sandbox";
import { buildChildRunResultSummary } from "../child-run/result-summary.ts";
import { UNCONFIRMED_AGENT_PROJECT_IDENTITY_MESSAGE } from "../project/context.ts";
Expand Down Expand Up @@ -66,7 +67,7 @@ function createTestOptions(input?: {
};
}

Deno.test("defaultHostedInvokeAgentInputSchema accepts child-agent selection", () => {
it("defaultHostedInvokeAgentInputSchema accepts child-agent selection", () => {
assertEquals(
defaultHostedInvokeAgentInputSchema.parse({
description: "inspect auth",
Expand All @@ -85,7 +86,7 @@ Deno.test("defaultHostedInvokeAgentInputSchema accepts child-agent selection", (
);
});

Deno.test("defaultHostedInvokeAgentInputSchema requires explicit child-agent selection", async () => {
it("defaultHostedInvokeAgentInputSchema requires explicit child-agent selection", async () => {
await assertRejects(
async () =>
defaultHostedInvokeAgentInputSchema.parse({
Expand All @@ -98,7 +99,7 @@ Deno.test("defaultHostedInvokeAgentInputSchema requires explicit child-agent sel
);
});

Deno.test("defaultHostedInvokeAgentInputSchema rejects blank child-agent selection", async () => {
it("defaultHostedInvokeAgentInputSchema rejects blank child-agent selection", async () => {
await assertRejects(
async () =>
defaultHostedInvokeAgentInputSchema.parse({
Expand All @@ -112,7 +113,7 @@ Deno.test("defaultHostedInvokeAgentInputSchema rejects blank child-agent selecti
);
});

Deno.test("defaultHostedInvokeAgentInputSchema rejects invalid result mode", async () => {
it("defaultHostedInvokeAgentInputSchema rejects invalid result mode", async () => {
await assertRejects(
async () =>
defaultHostedInvokeAgentInputSchema.parse({
Expand All @@ -127,7 +128,7 @@ Deno.test("defaultHostedInvokeAgentInputSchema rejects invalid result mode", asy
);
});

Deno.test("fixed hosted delegates inherit project-agent settings without overriding explicit input", () => {
it("fixed hosted delegates inherit project-agent settings without overriding explicit input", () => {
const configured = defaultHostedInvokeAgentToolInternals.applyChildAgentExecutionConfig(
{
description: "extract application",
Expand Down Expand Up @@ -160,7 +161,7 @@ Deno.test("fixed hosted delegates inherit project-agent settings without overrid
});
});

Deno.test("default hosted invoke resolves and runs configured child against the target project", async () => {
it("default hosted invoke resolves and runs configured child against the target project", async () => {
const captured: {
model?: string;
temperature?: number;
Expand Down Expand Up @@ -266,7 +267,90 @@ Deno.test("default hosted invoke resolves and runs configured child against the
assertEquals(captured.prompt?.includes("Extract the application."), true);
});

Deno.test("default hosted invoke rejects unconfirmed project identities before child setup", async () => {
describe("default hosted invoke agent", () => {
it("runs a generic local child with inherited assembled tools", async () => {
const context: DefaultHostedInvokeAgentContext = {
authToken: "token-123",
projectId: "project-123",
branchId: null,
model: "sonnet",
};
let capturedForkToolNames: readonly string[] | undefined;

const result = await executeDefaultHostedInvokeAgentTool(
createTestOptions({
context,
enableDurableInvokeAgent: false,
config: { mcpServers: [] },
options: {
resolveChildAgentExecutionConfig: (childAgentId, projectId) => {
assertEquals(childAgentId, "generic-agent");
assertEquals(projectId, "project-123");
return Promise.resolve(undefined);
},
buildGlobalTools: (toolContext, childAgentId, childConfig) => {
assertEquals(toolContext.projectId, "project-123");
assertEquals(toolContext.veryfrontInvocationContext, {
tool_call_id: "tool-call-generic-child",
delegation_depth: 1,
});
assertEquals(childAgentId, "generic-agent");
assertEquals(childConfig, undefined);
return {
lookup_job: {
description: "Lookup a job posting",
inputSchema: {},
execute: () => ({ ok: true }),
},
};
},
createAgentServiceSandboxTools: () =>
Promise.resolve({
tools: {},
sandbox: {} as never,
closeSandbox: () => Promise.resolve(),
}),
startRuntime: (input) => {
capturedForkToolNames = input.forkToolNames;
return {
forkStreamAbortController: new AbortController(),
childRunMonitorAbortController: null,
childRunMonitorPromise: Promise.resolve(),
forkToolNames: [...(input.forkToolNames ?? [])],
streamResult: {
fullStream: (async function* () {
yield { type: "text-delta", text: "Generic child ran." } as const;
})(),
steps: Promise.resolve([
{
text: "Generic child ran.",
finishReason: "stop",
messages: [],
toolCalls: [],
toolResults: [],
},
]),
totalUsage: Promise.resolve(undefined),
},
};
},
},
}),
{
description: "inspect application",
prompt: "Inspect the application.",
agent_id: "generic-agent",
},
"generic-agent",
{ toolCallId: "tool-call-generic-child" },
);

assertEquals("success" in result && result.success, true);
assertEquals(capturedForkToolNames, ["lookup_job", "sleep"]);
});
});

it("default hosted invoke rejects unconfirmed project identities before child setup", async () => {
const context: DefaultHostedInvokeAgentContext = {
authToken: "token-123",
projectId: "project-123",
Expand Down Expand Up @@ -323,7 +407,7 @@ Deno.test("default hosted invoke rejects unconfirmed project identities before c
});
});

Deno.test("executeDefaultHostedInvokeAgentTool returns durable context failure before local execution", async () => {
it("executeDefaultHostedInvokeAgentTool returns durable context failure before local execution", async () => {
const traceAttributes: DefaultHostedInvokeAgentTraceAttributes[] = [];
const result = await executeDefaultHostedInvokeAgentTool(
createTestOptions({ traceAttributes }),
Expand Down Expand Up @@ -351,7 +435,7 @@ Deno.test("executeDefaultHostedInvokeAgentTool returns durable context failure b
assertEquals(traceAttributes.at(-1)?.["tool.call.id"], "tool-call-1");
});

Deno.test("fixed delegates require durable execution even when legacy durable delegation is disabled", async () => {
it("fixed delegates require durable execution even when legacy durable delegation is disabled", async () => {
const result = await executeDefaultHostedInvokeAgentTool(
createTestOptions({
enableDurableInvokeAgent: false,
Expand All @@ -378,7 +462,7 @@ Deno.test("fixed delegates require durable execution even when legacy durable de
});
});

Deno.test("createDefaultHostedInvokeAgentTool adds child selection guidance and resolves agent_id", async () => {
it("createDefaultHostedInvokeAgentTool adds child selection guidance and resolves agent_id", async () => {
const traceAttributes: DefaultHostedInvokeAgentTraceAttributes[] = [];
const invokeTool = createDefaultHostedInvokeAgentTool(
createTestOptions({ traceAttributes }),
Expand Down Expand Up @@ -410,7 +494,7 @@ Deno.test("createDefaultHostedInvokeAgentTool adds child selection guidance and
assertEquals(traceAttributes.at(-1)?.["child.agent.id"], "custom-child");
});

Deno.test("createDefaultHostedInvokeAgentTool treats omitted context as empty structured context", async () => {
it("createDefaultHostedInvokeAgentTool treats omitted context as empty structured context", async () => {
const traceAttributes: DefaultHostedInvokeAgentTraceAttributes[] = [];
const invokeTool = createDefaultHostedInvokeAgentTool(
createTestOptions({ traceAttributes }),
Expand Down Expand Up @@ -439,7 +523,7 @@ Deno.test("createDefaultHostedInvokeAgentTool treats omitted context as empty st
assertEquals(traceAttributes.at(-1)?.["tool.call.id"], "tool-call-missing-context");
});

Deno.test("created invoke tools preserve distinct writer capabilities across concurrent execution", async () => {
it("created invoke tools preserve distinct writer capabilities across concurrent execution", async () => {
const originalFetch = globalThis.fetch;
const tokenRequests: Array<{ authorization: string | null; url: string }> = [];
const mirrorRequests: Array<{ authorization: string | null; url: string }> = [];
Expand Down
5 changes: 4 additions & 1 deletion src/agent/runtime/delegate-remote-tool-context.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@ Deno.test("local-only delegates preserve the trusted MCP source for a grandchild
let childModelCalls = 0;
let rootModelCalls = 0;
const listedBy: string[] = [];
let grandchildRuntimeToolNames: string[] = [];

const injectedStudioSource: RemoteToolSource = {
id: VERYFRONT_STUDIO_MCP_SOURCE_ID,
Expand All @@ -312,8 +313,9 @@ Deno.test("local-only delegates preserve the trusted MCP source for a grandchild
provider: "test",
modelId: "test/delegate-grandchild",
doGenerate: () => Promise.reject(new Error("unused")),
doStream() {
doStream(options) {
grandchildModelCalls++;
grandchildRuntimeToolNames = getRuntimeToolNames(options);
return Promise.resolve({
stream: createRuntimeStream([
{ type: "text-delta", text: "grandchild completed" },
Expand Down Expand Up @@ -433,6 +435,7 @@ Deno.test("local-only delegates preserve the trusted MCP source for a grandchild
assertEquals(childModelCalls, 2);
assertEquals(rootModelCalls, 2);
assertEquals(listedBy.includes(grandchildId), true);
assertEquals(grandchildRuntimeToolNames.includes("get_file"), true);
assertEquals(body.includes("root completed"), true);
assertEquals(body.includes('"type":"error"'), false);
} finally {
Expand Down