fix(extensions): keep optional Deno imports optional - #3542
Merged
Merged
Conversation
Deno 2.7.7 can report an unavailable first-party package as `Import "@veryfront/ext-auth-jwt" not a dependency` instead of the older `not a dependency and not in import map` wording. The classifier now accepts both forms so optional builtins remain optional when a scaffold does not install them. Constraint: Deno emits both shortened and older missing-dependency wording Rejected: Install optional auth extensions into every scaffold | the extension is not required for templates that do not use it Confidence: high Scope-risk: narrow Directive: Keep first-party missing-extension classification tolerant of runtime wording variants, but limited to explicitly probed first-party specifiers Tested: Focused RED then GREEN 1 test/29 steps; src/extensions suite 78/510; unit suite 3786/28100 with 1 ignored; fmt 4980; lint 4905; check src/index.ts; 21-case scaffold/install/production-build matrix when combined with PR #3541 Not-tested: none
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe missing-module parser now accepts Bun/Deno messages without an import-map clause. A test verifies that the parser recognizes a matching missing first-party package. ChangesMissing dependency parsing
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
kwakayama
added a commit
that referenced
this pull request
Aug 10, 2026
Ships the build fixes for veryfront-issue-inbox#456. `veryfront build` has been broken for every project since 0.1.1206, and 5 of 7 scaffold templates could not build at all. - #3538 prime host contracts in the build extension path - #3541 resolve server-side esm.sh modules with a server target - #3542 keep optional Deno imports optional - #3540 isolate cwd-mutating unit tests The version is embedded in hydration-runtime.generated.ts, so a bump must be followed by `deno task generate`; the manifests check fails otherwise. There is no earlier version to pin to: 0.1.1205 fails the same templates with the CSSProcessor error that #3417 was fixing.
This was referenced Aug 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deno 2.7.7 can report an unavailable optional first-party extension as:
The classifier accepted only the older wording,
not a dependency and not in import map, so build orchestration treated an absent optional builtin as a hard error for Deno scaffolds. The missing-extension regex now accepts both exact forms while still matching only the explicitly probed first-party specifier.PR #3541 is the independent SSG fix needed for the
ai-agentcase in the combined 21-case template matrix. This PR is the optional-extension classifier fix and does not depend on that change.Regression test
not a dependencywording.Verification
src/extensionssuite: 78 tests, 510 stepsdeno fmt --check: 4980 filesdeno lint: 4905 filesdeno check src/index.tsSummary by CodeRabbit
Bug Fixes
Tests