Skip to content

test: remove wall-clock races from pre-push suites - #3530

Merged
kojiwakayama merged 3 commits into
mainfrom
fix/issue-443-deterministic-time
Aug 10, 2026
Merged

test: remove wall-clock races from pre-push suites#3530
kojiwakayama merged 3 commits into
mainfrom
fix/issue-443-deterministic-time

Conversation

@kojiwakayama

Copy link
Copy Markdown
Contributor

Summary

  • drive buffered SSR timeout tests with an injected deadline runtime instead of 1-5 ms of host time
  • replace project environment timeout servers with abort-aware fetch mocks triggered by explicit test signals
  • give the Redis self-ack path a non-test deadline and bound it by event-loop turns instead of elapsed milliseconds

Closes veryfront/veryfront-issue-inbox#443

Verification

  • affected SSR, project environment, and Redis suites passed 20 consecutive runs each
  • deno test --preload=src/testing/preload.ts --no-check --allow-all src/react/compat/ssr-adapter/string-renderer.test.ts src/react/compat/ssr-adapter/stream-renderer.test.ts
  • deno test --preload=src/testing/preload.ts --no-check --allow-all src/server/project-env/fetcher.test.ts
  • deno test --preload=src/testing/preload.ts --no-check --allow-all src/proxy/routing-invalidation-redis.test.ts
  • deno task verify:quick
  • git diff --check

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@kojiwakayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 16 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9b55611e-984e-4e2d-abf5-620768f1c4b8

📥 Commits

Reviewing files that changed from the base of the PR and between a63ffc0 and 4042ace.

📒 Files selected for processing (6)
  • src/config/cicd-stable-release.test.ts
  • src/proxy/routing-invalidation-redis.test.ts
  • src/react/compat/ssr-adapter/string-renderer.test.ts
  • src/react/compat/ssr-adapter/string-renderer.ts
  • src/react/compat/ssr-adapter/timeout.ts
  • src/server/project-env/fetcher.test.ts

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f5c6c42fce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/proxy/routing-invalidation-redis.test.ts
@kojiwakayama
kojiwakayama added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit b6f5a42 Aug 10, 2026
31 checks passed
@kojiwakayama
kojiwakayama deleted the fix/issue-443-deterministic-time branch August 10, 2026 11:21
@kwakayama kwakayama mentioned this pull request Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant