fix(proxy): keep config workers out of binary graph - #3529
Conversation
|
Warning Review limit reached
Next review available in: 26 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe changes add a proxy dependency-graph test, document the proxy worker boundary, and update control-plane signature imports to use the dedicated input-validation limits module. ChangesProxy boundary enforcement
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/build/compile-binary.test.ts`:
- Around line 200-210: Validate the parsed `info` metadata before constructing
`modules` and `reachable`: require non-empty `roots` and `modules` arrays,
ensure every module has a non-empty `specifier`, and validate each dependency
has the expected object/code/specifier shape. Fail the test immediately for
missing or malformed graph metadata, then preserve the existing graph traversal
and regression assertion for valid data.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 4c26d4e1-b270-4ef5-895d-f5a85d07e0e2
📒 Files selected for processing (3)
scripts/build/compile-binary.test.tsscripts/build/compile-binary.tssrc/proxy/control-plane-signature.ts
Summary
Closes veryfront/veryfront-issue-inbox#382
Verification
deno fmt --check scripts/build/compile-binary.ts scripts/build/compile-binary.test.ts src/proxy/control-plane-signature.tsdeno lint --config=scripts/test.deno.json scripts/build/compile-binary.ts scripts/build/compile-binary.test.tsdeno lint src/proxy/control-plane-signature.tsdeno check --config=scripts/test.deno.json scripts/build/compile-binary.test.tsdeno check src/proxy/control-plane-signature.tsdeno test --config=scripts/test.deno.json --no-check --allow-read --allow-write --allow-run scripts/build/compile-binary.test.tsdeno test --preload=src/testing/preload.ts --no-check --allow-all src/proxy/control-plane-signature.test.ts src/proxy/control-plane-signature.api-contract.test.tsgit diff --checkSummary by CodeRabbit