Skip to content

fix(deps): bump nanoid and fast-uri past their advisories - #3479

Merged
kwakayama merged 1 commit into
mainfrom
worktree-fix-dependabot-transitive-bumps
Aug 8, 2026
Merged

fix(deps): bump nanoid and fast-uri past their advisories#3479
kwakayama merged 1 commit into
mainfrom
worktree-fix-dependabot-transitive-bumps

Conversation

@kojiwakayama

Copy link
Copy Markdown
Contributor

Closes both open high-severity Dependabot alerts on main.

What they are

Both resolve into the root deno.lock as transitive npm dependencies of extensions:

Package Was Now Reached via Advisory
nanoid 3.3.16 3.3.18 purgecss@8.0.0postcss (ext-css-purgecss) GHSA-2v37-7h3g-55p8 — custom generators can loop indefinitely when size is 0
fast-uri 3.1.4 3.1.5 ajv@8.18.0 (ext-schema-zod) host confusion via a backslash in the authority

#3466 already bumped nanoid, but in storybook/package-lock.json — a separate surface. The deno.lock copy was never moved, which is why the alert stayed open. The integrity hash for 3.3.18 here matches the one that PR landed, which is an independent check that this is the right tarball.

Why the lock alone

Both dependents reference the bare package name in deno.lock, so bumping the key and integrity is sufficient — neither extension's deno.json pins a range that needed to move.

Verification

  • deno check passes on both extensions/ext-css-purgecss/src/index.ts and extensions/ext-schema-zod/src/index.ts, so Deno re-resolved and integrity-verified both new tarballs
  • The lock did not drift: the diff is exactly the four intended lines
  • Extension tests: 6 passed / 3 failed both with and without this bump. The three failures (GCS blob storage, S3 blob storage, ws package boundary) are pre-existing and unrelated — I stashed the change and re-ran to confirm, since the ws test is a package-boundary check that could plausibly have been affected

Two open high-severity Dependabot alerts resolve into the root deno.lock as
transitive npm dependencies of extensions:

  nanoid 3.3.16  <- postcss <- purgecss@8.0.0  (ext-css-purgecss)
    GHSA-2v37-7h3g-55p8, custom generators can loop indefinitely when size is 0
  fast-uri 3.1.4 <- ajv@8.18.0                 (ext-schema-zod)
    host confusion via a backslash in the authority

#3466 fixed nanoid in storybook/package-lock.json, which is a separate surface;
the deno.lock copy was never bumped. The nanoid integrity here matches the hash
that PR landed, which is an independent check that 3.3.18 is the right tarball.

Both dependents reference the bare package name, so bumping the lock key and
integrity is sufficient -- no range in either extension's deno.json needed to
move. Deno re-resolved and verified both tarballs: `deno check` passes on both
extension entry points, and the lock did not drift beyond these four lines.

Extension tests are unchanged: 6 passed / 3 failed both with and without this
bump. Those three (GCS and S3 blob storage, the ws package boundary) are
pre-existing and unrelated to either package.
@kojiwakayama
kojiwakayama requested a review from kwakayama as a code owner August 8, 2026 18:36
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • deno.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e95e8f33-3792-4f39-acbf-8e714bdc2c68

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@kwakayama
kwakayama added this pull request to the merge queue Aug 8, 2026
Merged via the queue into main with commit 396477b Aug 8, 2026
31 checks passed
@kwakayama
kwakayama deleted the worktree-fix-dependabot-transitive-bumps branch August 8, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants