fix(deps): bump nanoid and fast-uri past their advisories - #3479
Merged
Conversation
Two open high-severity Dependabot alerts resolve into the root deno.lock as
transitive npm dependencies of extensions:
nanoid 3.3.16 <- postcss <- purgecss@8.0.0 (ext-css-purgecss)
GHSA-2v37-7h3g-55p8, custom generators can loop indefinitely when size is 0
fast-uri 3.1.4 <- ajv@8.18.0 (ext-schema-zod)
host confusion via a backslash in the authority
#3466 fixed nanoid in storybook/package-lock.json, which is a separate surface;
the deno.lock copy was never bumped. The nanoid integrity here matches the hash
that PR landed, which is an independent check that 3.3.18 is the right tarball.
Both dependents reference the bare package name, so bumping the lock key and
integrity is sufficient -- no range in either extension's deno.json needed to
move. Deno re-resolved and verified both tarballs: `deno check` passes on both
extension entry points, and the lock did not drift beyond these four lines.
Extension tests are unchanged: 6 passed / 3 failed both with and without this
bump. Those three (GCS and S3 blob storage, the ws package boundary) are
pre-existing and unrelated to either package.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes both open high-severity Dependabot alerts on
main.What they are
Both resolve into the root
deno.lockas transitive npm dependencies of extensions:nanoidpurgecss@8.0.0→postcss(ext-css-purgecss)fast-uriajv@8.18.0(ext-schema-zod)#3466 already bumped nanoid, but in
storybook/package-lock.json— a separate surface. Thedeno.lockcopy was never moved, which is why the alert stayed open. The integrity hash for 3.3.18 here matches the one that PR landed, which is an independent check that this is the right tarball.Why the lock alone
Both dependents reference the bare package name in
deno.lock, so bumping the key and integrity is sufficient — neither extension'sdeno.jsonpins a range that needed to move.Verification
deno checkpasses on bothextensions/ext-css-purgecss/src/index.tsandextensions/ext-schema-zod/src/index.ts, so Deno re-resolved and integrity-verified both new tarballs