Skip to content

test(ui): poll for the copy failure state instead of a fixed tick budget #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwakayama merged 1 commit into from
Aug 8, 2026
Merged

test(ui): poll for the copy failure state instead of a fixed tick budget #3476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions src/react/components/ui/code-block.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,25 @@ async function settle(): Promise<void> {
flushSync(() => {});
}

/**
* Wait for a condition the copy handler reaches asynchronously.
*
* `settle` spends a fixed budget of one microtask and one macrotask, which is
* enough for the success path but not reliably for the failure path: a rejected
* `clipboard.writeText` falls back to `execCommand`, and only once that returns
* false does the failed state get set. That chain is several ticks long, so on
* a loaded machine the assertion could run against the pre-failure render. Poll
* for the state the test is actually about instead of guessing a tick count.
*/
async function waitFor(predicate: () => boolean, description: string): Promise<void> {
for (let attempt = 0; attempt < 100; attempt += 1) {
flushSync(() => {});
if (predicate()) return;
await new Promise((resolve) => setTimeout(resolve, 1));
}
throw new Error(`Timed out waiting for ${description}`);
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}

/**
* Unmount and drain the one-shot tasks the runtime leaves behind.
*
Expand Down Expand Up @@ -351,7 +370,10 @@ describe("CodeBlock clipboard integration", () => {
assert(button, "copy control renders");

button.dispatchEvent(new dom.window.MouseEvent("click", { bubbles: true }));
await settle();
await waitFor(
() => button.dataset.failed === "true",
"both clipboard mechanisms to fail",
);

assertEquals(button.dataset.copied, "false");
assertEquals(button.dataset.failed, "true");
Expand Down Expand Up @@ -383,7 +405,10 @@ describe("CodeBlock clipboard integration", () => {
assert(button, "copy control renders");

button.dispatchEvent(new dom.window.MouseEvent("click", { bubbles: true }));
await settle();
await waitFor(
() => button.getAttribute("aria-label") === "Unable to copy code",
"the copy control to report failure",
);

assertEquals(button.getAttribute("aria-label"), "Unable to copy code");
assertEquals(
Expand Down