Skip to content

refactor(chat): give tool replay reconciliation its own module #3439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwakayama merged 9 commits into from
Aug 7, 2026
Merged

refactor(chat): give tool replay reconciliation its own module #3439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
664b24f
refactor(chat): give untrusted-field reading its own module
kojiwakayama Aug 6, 2026
0a57b26
refactor(chat): give tool-part interpretation its own module
kojiwakayama Aug 6, 2026
2aee96b
refactor(chat): give tool replay reconciliation its own module
kojiwakayama Aug 6, 2026
95d17d4
refactor(chat): move non-tool part predicates into tool-part-parsing
kojiwakayama Aug 6, 2026
e6fa5b9
chore(chat): pin core chat module sizes and record domain terms
kojiwakayama Aug 6, 2026
4216a85
polish(chat): rename tool-part-parsing to message-part-parsing, tidy …
kojiwakayama Aug 6, 2026
f14619d
fix: correct false comment about cycle detection in module-boundaries…
kojiwakayama Aug 6, 2026
1eba258
test(chat): cover the tool-replay reconciliation algorithm directly (…
kojiwakayama Aug 7, 2026
67ffa89
test(chat): close the parsing coverage gaps; dedupe JsonValue
kwakayama Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions CONTEXT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,23 @@ never the decision. There is exactly one persisted link format
(inferred or local-link) and never on a dry run. The project client
(control plane over HTTP, CLI API client, fake in tests) is its one seam.

## Tool Replay Reconciliation

The single owner of deciding which tool-call and tool-result occurrences in
UI-message replay history are authoritative for provider conversion:
`src/chat/tool-replay-reconciliation.ts`. Matching is by part **object
identity**, so one pass over history marks parts as matched, superseded,
batch-starting, or transient-but-preserved without mutating them. Provider
conversion and message preparation both consult this module rather than
re-deriving which occurrence wins.

## Message Part Interpretation

The single owner of interpreting one message part — tool, text, reasoning, or
file — into a normalized shape: `src/chat/message-part-parsing.ts`. Provider
conversion and Tool Replay Reconciliation both read parts through it, so a
change to how a part is recognized lands in one file.

## Stream Delivery

The separate agent-loop fan-out boundary that will route lifecycle frames to
Expand Down
9 changes: 9 additions & 0 deletions scripts/lint/ban-chat-antipatterns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,15 @@ const FILE_SIZE_CEILINGS: Record<string, number> = {
"src/react/components/chat/chat-actions.tsx": 203,
"src/react/components/chat/chat/controlled-chat.tsx": 242,
"src/react/components/chat/chat/app-mode-chat.tsx": 177,
// Chat core: message construction and provider-conversion, split along its
// real seams (part-field-access, message-part-parsing, tool-replay
// reconciliation). Not React components, so this map does not subject them
// to the antipattern ratchets above — it only pins their size.
"src/chat/conversation.ts": 1018,
"src/chat/message-prep.ts": 2016,
"src/chat/tool-replay-reconciliation.ts": 294,
"src/chat/message-part-parsing.ts": 264,
"src/chat/part-field-access.ts": 66,
};

function checkFileSizes(): boolean {
Expand Down
Loading