-
Notifications
You must be signed in to change notification settings - Fork 0
fix(cache): key proxy adapters by environmentName in preview mode #3372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1f24b04
fix(cache): key proxy adapters by environmentName in preview mode
kwakayama d57fd83
fix(hmr,cache): align adapter identity with the cache key
kwakayama af94de7
fix(hmr): warm the adapter for the named environment, not the mode
kwakayama f219f5c
fix(cache): pin preview releaseId to null and harden identity tests
kwakayama 31cdf42
docs(cache): correct the identity normalization comment
kwakayama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed — the collision is closed on the identity side rather than in the key.
proxy-manager.ts:129now normalizes with the same truthiness predicate the key builder uses:So
""andnullproduce both the same key and the same identity — they can no longer diverge, which was the actual failure mode (the key omitted the segment while?? nullkept""in the identity, so the reuse assertion threw).The other call site,
buildDiagnosticCacheKeyatproxy-manager.ts:52, is fed already-normalized identity fields, so it cannot reintroduce the split.Covered by
proxy-manager.test.ts"treats an empty environment name as unnamed", which assertsassertStrictEquals(empty, unnamed)and fails when the normalization is reverted.