Skip to content

test(import-map): stop racing wall time in preloader capacity tests #3370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwakayama merged 1 commit into from
Aug 5, 2026
Merged

test(import-map): stop racing wall time in preloader capacity tests #3370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/modules/import-map/preloader.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ import type { RuntimeAdapter } from "#veryfront/platform/adapters/base.ts";
import { MAX_TIMER_DELAY_MS } from "#veryfront/utils/constants/limits.ts";
import type { ImportMapConfig } from "./types.ts";

/**
* `loadTimeoutMs` arms a real `setTimeout`, not the injected `now` clock, so
* tests holding a load unresolved race wall time and flake under CI load. Tests
* that do exercise timeout behavior keep their own small values.
*/
const TIMEOUT_NOT_UNDER_TEST_MS = 600_000;

function createMinimalAdapter(): RuntimeAdapter {
return {
fs: {
Expand Down Expand Up @@ -1135,7 +1142,7 @@ describe("modules/import-map/preloader", () => {
maxProjects: 2,
maxVariantsPerProject: 1,
ttlMs: 1_000,
loadTimeoutMs: 1_000,
loadTimeoutMs: TIMEOUT_NOT_UNDER_TEST_MS,
loadImportMap: () => {
const load = createDeferred<ImportMapConfig>();
loads.push(load);
Expand Down Expand Up @@ -1223,7 +1230,7 @@ describe("modules/import-map/preloader", () => {
maxProjects: 2,
maxVariantsPerProject: 2,
ttlMs: 1_000,
loadTimeoutMs: 1_000,
loadTimeoutMs: TIMEOUT_NOT_UNDER_TEST_MS,
loadImportMap: () => {
const load = createDeferred<ImportMapConfig>();
loads.push(load);
Expand Down Expand Up @@ -1296,7 +1303,7 @@ describe("modules/import-map/preloader", () => {
maxProjects: 1,
maxVariantsPerProject: 2,
ttlMs: 1_000,
loadTimeoutMs: 10_000,
loadTimeoutMs: TIMEOUT_NOT_UNDER_TEST_MS,
now: () => {
if (releaseDuringAdmission && admissionClockReads++ === 0) {
loads[0]!.resolve({ imports: { source: "a" } });
Expand Down