Skip to content

fix: embed framework sources in cross-compiled binaries #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwakayama merged 1 commit into from
Feb 9, 2026
Merged

fix: embed framework sources in cross-compiled binaries #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/cicd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,13 +177,17 @@ jobs:
deno-version: lts

- run: deno run -A scripts/build/generate-templates-manifest.ts
- run: deno run -A scripts/build/prepare-framework-sources.ts

Comment on lines 179 to 181

Copilot AI Feb 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new prepare-framework-sources.ts step will run in the Windows matrix as well. That script currently derives FRAMEWORK_ROOT from new URL(..., import.meta.url).pathname, which produces POSIX-style /C:/... paths on Windows and is not a reliable filesystem path. This can break the Windows build leg (and later release steps that expect a Windows artifact). Consider either making the script use a proper file-URL-to-path conversion (e.g., std/compat fromFileUrl / fileURLToPath) or gating the step to non-Windows runners until the script is Windows-safe.

Copilot uses AI. Check for mistakes.
- name: Compile binary
shell: bash
run: |
# React is fetched at runtime through the module server (SSR transform pipeline)
# Include Tailwind CSS v4 plugins (versions must match PINNED_PLUGIN_VERSIONS in tailwind-compiler.ts)
deno compile --allow-all --unstable-net \
--include src/platform/polyfills \
--include src/proxy/main.ts \
--include dist/framework-src \
--include "https://esm.sh/tailwindcss-animate@1.0.7" \
--include "https://esm.sh/@tailwindcss/typography@0.5.19" \
--include "https://esm.sh/@tailwindcss/forms@0.5.11" \
Expand Down