Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use request-scoped project agent config in hosted chat #2724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Use request-scoped project agent config in hosted chat #2724
Changes from 1 commit
3c09a0b42c617c1257be7eb98fc9b4f31daefeb4b3File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an invocation includes this new field,
buildRuntimeAgentControlPlaneStreamRequestFromInvocationnow emitsagentConfig, butAgentStreamHandlerparses that transformed object withgetInternalAgentStreamRequestSchema(), whose control-plane schema insrc/internal-agents/schema.tsis.strict()and has noagentConfigfield. In that environment, any runtime invocation carrying a request-scoped project agent config is accepted byRuntimeAgentRunInvocationSchemaand then rejected as an invalid internal agent stream request before streaming, so the new project-agent-config path cannot work through/api/control-plane/runs/.../streamuntil the strict schema accepts the field.Useful? React with 👍 / 👎.