Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 74 additions & 0 deletions src/discovery/file-discovery.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
import "#veryfront/schemas/_test-setup.ts";
import { assertEquals } from "#veryfront/testing/assert.ts";
import { discoveryFileExists, listDiscoveryDirectoryEntries } from "./file-discovery.ts";
import type { FileDiscoveryContext } from "./types.ts";
import type { FileSystemAdapter } from "#veryfront/platform/adapters/base.ts";

type FakeEntry = { name: string; isFile: boolean; isDirectory: boolean };

function fakeFsAdapter(tree: Record<string, FakeEntry[]>, files: Set<string>): FileSystemAdapter {
return {
exists: (path: string) => Promise.resolve(path in tree || files.has(path)),
readDir: async function* (path: string) {
for (const entry of tree[path] ?? []) {
yield entry;
}
},
readFile: (path: string) => Promise.resolve(`content:${path}`),
} as unknown as FileSystemAdapter;
}

Deno.test("listDiscoveryDirectoryEntries reads top-level entries through an fsAdapter", async () => {
const fsAdapter = fakeFsAdapter(
{
"/agents": [
{ name: "lead.md", isFile: true, isDirectory: false },
{ name: "writer", isFile: false, isDirectory: true },
],
},
new Set(),
);
const context: FileDiscoveryContext = { platform: "node", fsAdapter };

const entries = await listDiscoveryDirectoryEntries("/agents", context);

assertEquals(entries, [
{ name: "lead.md", isFile: true, isDirectory: false },
{ name: "writer", isFile: false, isDirectory: true },
]);
});

Deno.test("listDiscoveryDirectoryEntries returns empty for a missing dir via fsAdapter", async () => {
const fsAdapter = fakeFsAdapter({}, new Set());
const context: FileDiscoveryContext = { platform: "node", fsAdapter };

assertEquals(await listDiscoveryDirectoryEntries("/missing", context), []);
});

Deno.test("listDiscoveryDirectoryEntries reads top-level entries through the Node fallback", async () => {
const root = await Deno.makeTempDir();
try {
await Deno.writeTextFile(`${root}/lead.md`, "Lead");
await Deno.mkdir(`${root}/writer`);
await Deno.writeTextFile(`${root}/writer/AGENT.md`, "Writer");
const context: FileDiscoveryContext = { platform: "node" };

const entries = (await listDiscoveryDirectoryEntries(root, context))
.sort((a, b) => a.name.localeCompare(b.name));

assertEquals(entries, [
{ name: "lead.md", isFile: true, isDirectory: false },
{ name: "writer", isFile: false, isDirectory: true },
]);
} finally {
await Deno.remove(root, { recursive: true });
}
});

Deno.test("discoveryFileExists resolves through an fsAdapter", async () => {
const fsAdapter = fakeFsAdapter({}, new Set(["/agents/writer/AGENT.md"]));
const context: FileDiscoveryContext = { platform: "node", fsAdapter };

assertEquals(await discoveryFileExists("/agents/writer/AGENT.md", context), true);
assertEquals(await discoveryFileExists("/agents/writer/SKILL.md", context), false);
});
63 changes: 63 additions & 0 deletions src/discovery/file-discovery.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,3 +107,66 @@ export async function readDiscoveryTextFile(
const { fs } = await getNodeDeps(context);
return fs.readFileSync(path, "utf-8");
}

/** A single top-level entry inside a discovery directory. */
export type DiscoveryDirectoryEntry = {
name: string;
isFile: boolean;
isDirectory: boolean;
};

/** Lists the immediate (non-recursive) entries of a discovery directory. */
export async function listDiscoveryDirectoryEntries(
dir: string,
context: FileDiscoveryContext,
): Promise<DiscoveryDirectoryEntry[]> {
const entries: DiscoveryDirectoryEntry[] = [];

try {
if (context.fsAdapter) {
if (!(await context.fsAdapter.exists(dir))) return entries;

for await (const entry of context.fsAdapter.readDir(dir)) {
entries.push({
name: entry.name,
isFile: entry.isFile,
isDirectory: entry.isDirectory,
});
}

return entries;
}

const { fs } = await getNodeDeps(context);
if (!fs.existsSync(dir)) return entries;

for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
entries.push({
name: entry.name,
isFile: entry.isFile(),
isDirectory: entry.isDirectory(),
});
}
} catch (_) {
/* expected: directory may not exist or be unreadable */
return entries;
}

return entries;
}

/** Returns true when a discovery file exists (fsAdapter-aware). */
export async function discoveryFileExists(
path: string,
context: FileDiscoveryContext,
): Promise<boolean> {
try {
if (context.fsAdapter) {
return await context.fsAdapter.exists(path);
}
const { fs } = await getNodeDeps(context);
return fs.existsSync(path);
} catch (_) {
return false;
}
}
Loading