Fix M600 / Compile Issue for Taller Frame (Zaribo etc) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M600 Z_MAX_POS
M600 Z_MAX_POS
Make the simple 4 axis stepper control respect the axis inversion settings in Configuration_prusa.h THX metacollin
|
I had seen metacolin's PR for the inversion prusa3d/Prusa-Firmware#1263 What is this used for? |
All LCD Menu
|
Looks like the sketch is too big in your latest change to the LCD. I'm not interested in deviating too deeply from prusa base, can you include only fixes for the 320mm, and possibly this inversion change if you can explain what it's for. This change does not require any updates to the configuration_prusa does it? |
|
OK nevermind, I see the direction inverting defines are already in there, this just uses them instead of the hard coded values. I'm inclined to merge but I need you to remove this lcd change you just pushed. |
|
I'm merging the M600 fix, but not the other things at the moment. |
vertigo235
changed the title
Closed
vertigo235
pushed a commit
that referenced
this pull request
Sep 20, 2019
Added doxygen todos for missing LCD layout and positioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zmax 320 and more ,invert direction now works in Configuration_Prusa. works for me fine