Completed futures should not park #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 28, 2022 12:57
Signed-off-by: Benjamin Berman <[email protected]>
Signed-off-by: Benjamin Berman <[email protected]>
vietj
reviewed
Jan 5, 2023
| var flag = new AtomicInteger(); | ||
| async.run(v -> { | ||
| var completed = Future.succeededFuture("HELLO"); | ||
| vertx.getOrCreateContext().runOnContext(v2 -> { |
There was a problem hiding this comment.
I don't think we need this we can simply call testComplete after the await
vietj
reviewed
Jan 5, 2023
| var flag = new AtomicInteger(); | ||
| async.run(v -> { | ||
| var completed = Future.failedFuture("FAILED"); | ||
| vertx.getOrCreateContext().runOnContext(v2 -> { |
There was a problem hiding this comment.
I don't think we need this, we can simply call testComplete in the catch block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Already completed futures should not park the thread. Currently, they do. This can improve performance.
This also resolves an ordering issue in the default event loop context.