Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPUB Media Overlays support and migration from Json.NET to System.Text.Json #78

Merged
merged 14 commits into from
May 7, 2023

Conversation

vers-one
Copy link
Owner

@vers-one vers-one commented Feb 14, 2023

EPUB Media Overlays support and migration from Json.NET to System.Text.Json

This is:

  • a bug fix
  • an enhancement

Related issues: #64, #77.

Description

This pull request:

  1. Parses all SMIL files found in the EPUB book into a collection of VersOne.Epub.Schema.Smil objects.
  2. Migrates integration tests from using Json.NET to System.Text.Json

Testing steps

  1. Open a EPUB book with media overlays and inspect the EpubBook.Schema.MediaOverlays property. This property should contain the list of all parsed SMIL objects that correspond to the media overlay files included in the EPUB book.
  2. All integration tests should continue to pass.

@vers-one vers-one marked this pull request as ready for review May 7, 2023 03:32
@vers-one vers-one merged commit 02305b8 into master May 7, 2023
@vers-one vers-one deleted the media-overlays branch May 7, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate integration tests from using Json.NET to System.Text.Json EPUB Media Overlays support
1 participant