Fix for EPUB 2 NCX navigation list parsing #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
===========================================
+ Coverage 31.62% 48.53% +16.91%
===========================================
Files 80 80
Lines 2084 2087 +3
Branches 221 221
===========================================
+ Hits 659 1013 +354
+ Misses 1419 1068 -351
Partials 6 6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was
linked to
issues
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for EPUB 2 NCX navigation list parsing
This is:
Related issue: #55
Description
This pull request fixes the EPUB 2 NCX navigation list parsing issues described in the issue linked above. It also adds unit tests for the EPUB 2 NCX reader.
Testing steps
book.Schema.Schema.Epub2Ncx.NavLists[0].NavigationTargetsproperty and make sure it contains at least one element.