Add the configuration option to ignore the error for missing manifest item referenced by EPUB 2 cover metadata #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the configuration option to ignore the error for missing manifest item referenced by EPUB 2 cover metadata
This is:
Related issue: #109
Description
One of most common errors in real-world EPUB 2 books is the situation when the book contains a EPUB 2 cover metadata referencing a non-existing manifest item:
In such situations, EpubReader was throwing a
EpubPackageExceptionwith the following message:which prevented the app from opening the book.
This pull request adds the
BookCoverReaderOptions.Epub2MetadataIgnoreMissingManifestItemproperty to let the applications ignore this error. This property is set totruewhen the application is using theEpubReaderOptionsPreset.RELAXEDorEpubReaderOptionsPreset.IGNORE_ALL_ERRORSconfiguration preset or passingnullas theepubReaderOptionsparameter in one of theEpubReadermethods. In all other cases, this property is set tofalse.Testing steps
Try to open a EPUB 2 book with the metadata item above.