Repository navigation
Conversation
Compare token support, normalization, loss/config names, and JSD beta endpoints between mainline OPD and the standalone GKD recipe. Point to existing examples and distinguish forward expressions from update behavior. AI-assisted with OpenAI Codex. Assisted-by: OpenAI Codex Signed-off-by: Qianli Liu <73509271+Liu-KM@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Users moving between mainline OPD and
verl-recipe/gkdcan select similarly named losses with different token support and normalization. Add a source-backed comparison to the OPD guide covering sampled-token estimators, teacher top-k objectives, config namespaces, migration choices, and the recipe's JSD beta clamping. Reuse the existing GKD/PG examples and distinguish raw loss/gradient scaling from optimizer updates.Fixes #7975. This changes documentation only; the comparison is pinned to recipe commit
5451026758c3f1dc3ebc2a46a0e52b14406f0f72.Checklist Before Starting
[doc] fix:format.Test
The following checks were run with AI assistance.
git diff --check— passed.pre-commit run check-docs-time-info --files docs/algo/opd.md --show-diff-on-failure— passed.sphinx-build -E -a -b html docs /tmp/verl-7975-docs-html— succeeded with 323 warnings in an isolated documentation environment. An unmodified-mainline build in the same environment produced the same 323 warnings; normalized warning contents matched exactly. Checked the generated comparison table, math markup, and source links.API and Usage Example
No API changes. The new section links the existing GKD and PG OPD examples to the corresponding loss/config choices.
Design & Code Changes
One comparison subsection in
docs/algo/opd.md, plus its last-updated date.Checklist Before Submitting
AI assistance was used to inspect both implementations, prepare the patch, run the listed checks, and perform an independent source review. This PR is a draft pending the human submitter's line-by-line review and execution of relevant checks required by AGENTS.md.