Skip to content

[misc] feat: add weight decay option in config#611

Merged
PeterSH6 merged 1 commit intogm-tyx/puffin/mainfrom
gm/add_weight_decay
Mar 15, 2025
Merged

[misc] feat: add weight decay option in config#611
PeterSH6 merged 1 commit intogm-tyx/puffin/mainfrom
gm/add_weight_decay

Conversation

@PeterSH6
Copy link
Copy Markdown
Collaborator

  • As titled

@PeterSH6 PeterSH6 merged commit f39fae6 into gm-tyx/puffin/main Mar 15, 2025
3 checks passed
@PeterSH6 PeterSH6 deleted the gm/add_weight_decay branch March 15, 2025 13:23
FortPercent pushed a commit to HyperdriveHustle/verl that referenced this pull request May 15, 2025
HyperdriveHustle pushed a commit to HyperdriveHustle/verl that referenced this pull request May 23, 2025
dreamyang-liu pushed a commit to dreamyang-liu/verl-sagemaker that referenced this pull request Feb 21, 2026
The test was flaky due to race conditions:
1. Thread started before UI was fully mounted
2. Used fixed 0.2s timeout instead of waiting for notify

Changes:
- Wait 0.2s for UI to be ready before starting thread
- Poll for notify.call_count > 0 with 5s timeout
- Consistent with other tests like test_agent_with_cost_limit

Fixes verl-project#606
dreamyang-liu pushed a commit to dreamyang-liu/verl-sagemaker that referenced this pull request Feb 21, 2026
…-project#620)

* CI: Make test_whitelist_actions_bypass_confirmation more robust (verl-project#484)

The test was flaky due to race conditions:
1. Thread started before UI was fully mounted
2. Used fixed 0.2s timeout instead of polling

Changes:
- Wait 0.2s for UI to be ready before starting thread
- Poll for command to appear in screen with 5s timeout
- Consistent with fix in verl-project#611 for test_log_message_filtering

Fixes verl-project#484

* Update tests/agents/test_interactive_textual.py

---------

Co-authored-by: Kilian Lieret <kilian.lieret@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant