[fully_async, one_step_off] feat: support auto resume on abort when using fully_async#5487
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a significant refactoring of the fully_async policy to support automatic resumption of aborted rollouts. The changes simplify the architecture by removing the explicit cancel_queue and dedicated partial agent loops, integrating the retry logic directly into the FullyAsyncLLMServerManager. This refactoring also includes better code organization by moving utility functions and enhances robustness in asynchronous task handling through the new safe_create_task utility. The review comment highlights a critical aspect of robust asynchronous task handling by recommending proper exception logging in done_callbacks, which aligns with the goal of enhancing reliability.
| except Exception as e: | ||
| print(f"Task {task.get_name()} failed with exception: {e}") | ||
| raise e |
There was a problem hiding this comment.
Raising an exception from a done_callback is not recommended. The exception is not propagated to the task's creator and is instead handled by the event loop's exception handler. This can lead to ungraceful process termination or hard-to-debug silent failures. It's better to log the exception with a full traceback here. If a failure in a task should stop the entire application, it should be done via a more explicit and graceful shutdown mechanism.
| except Exception as e: | |
| print(f"Task {task.get_name()} failed with exception: {e}") | |
| raise e | |
| except Exception: | |
| import logging | |
| import traceback | |
| logging.error(f"Task {task.get_name()} failed with exception:\n{traceback.format_exc()}") |
| group_name=self.sync_group_name, | ||
| ) | ||
|
|
||
| def sync_weights(self, version, validate=False, global_steps=0, use_trainer_do_validate=False): |
There was a problem hiding this comment.
Do we still need a remote ParameterSynchronizer? Could it be absorb into FullyAsyncTrainer?
There was a problem hiding this comment.
Yes, it should work. The core logic has been moved over.
| actor_rollout_ref.actor.entropy_coeff=0 | ||
| actor_rollout_ref.actor.loss_agg_mode=${loss_agg_mode} | ||
| actor_rollout_ref.rollout.gpu_memory_utilization=0.70 | ||
| actor_rollout_ref.rollout.gpu_memory_utilization=0.50 |
There was a problem hiding this comment.
Why should gpu_memory_utilization be set so low? It's preferred to set expandable memory instead of decrease gpu_memory_utilization:
export PYTORCH_NPU_ALLOC_CONF="expandable_segments:True"
+actor_rollout_ref.rollout.enable_sleep_mode=False
There was a problem hiding this comment.
just for ci oom,
Maybe I can submit a separate PR next time to modify the part you mentioned.
|
Why changed the extra_info to extra_fields? |
|
Since AgentLoopOutput, AgentData, and _InternalAgentLoopOutput all use |
…sing fully_async (verl-project#5487) ### What does this PR do? Refactor the fully_async code based on verl-project#5430 to support the gateway mode, and decouple the tool invocation and rollout processes during the partial rollout phase. Feature `use_trainer_do_validate` is not ready for use, I will fix it in a subsequent PR. <img width="708" height="564" alt="image" src="https://github.com/user-attachments/assets/18e282ea-a4cf-43bc-ae1f-b4108eee8dfd" /> ### Checklist Before Starting - [x] Search for similar PRs. Paste at least one query link here: ... - [x] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `veomni`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data`, `cfg`, `reward`, `fully_async`, `one_step_off` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [x] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [x] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [x] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [x] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).) - [x] If your PR is related to the `recipe` submodule, please also update the reference to the submodule commit via `git submodule update --remote` or `cd recipe && git pull origin main`.
…sing fully_async (verl-project#5487) ### What does this PR do? Refactor the fully_async code based on verl-project#5430 to support the gateway mode, and decouple the tool invocation and rollout processes during the partial rollout phase. Feature `use_trainer_do_validate` is not ready for use, I will fix it in a subsequent PR. <img width="708" height="564" alt="image" src="https://github.com/user-attachments/assets/18e282ea-a4cf-43bc-ae1f-b4108eee8dfd" /> ### Checklist Before Starting - [x] Search for similar PRs. Paste at least one query link here: ... - [x] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `veomni`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data`, `cfg`, `reward`, `fully_async`, `one_step_off` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [x] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [x] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [x] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [x] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).) - [x] If your PR is related to the `recipe` submodule, please also update the reference to the submodule commit via `git submodule update --remote` or `cd recipe && git pull origin main`.
…sing fully_async (verl-project#5487) ### What does this PR do? Refactor the fully_async code based on verl-project#5430 to support the gateway mode, and decouple the tool invocation and rollout processes during the partial rollout phase. Feature `use_trainer_do_validate` is not ready for use, I will fix it in a subsequent PR. <img width="708" height="564" alt="image" src="https://github.com/user-attachments/assets/18e282ea-a4cf-43bc-ae1f-b4108eee8dfd" /> ### Checklist Before Starting - [x] Search for similar PRs. Paste at least one query link here: ... - [x] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `veomni`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data`, `cfg`, `reward`, `fully_async`, `one_step_off` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [x] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [x] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [x] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [x] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).) - [x] If your PR is related to the `recipe` submodule, please also update the reference to the submodule commit via `git submodule update --remote` or `cd recipe && git pull origin main`.
What does this PR do?
Refactor the fully_async code based on #5430 to support the gateway mode, and decouple the tool invocation and rollout processes during the partial rollout phase.
Feature
use_trainer_do_validateis not ready for use, I will fix it in a subsequent PR.Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,veomni,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,cfg,reward,fully_async,one_step_off,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)recipesubmodule, please also update the reference to the submodule commit viagit submodule update --remoteorcd recipe && git pull origin main.