Skip to content

[fully_async, one_step_off] feat: support auto resume on abort when using fully_async#5487

Merged
wuxibin89 merged 23 commits intoverl-project:mainfrom
meituan-search:refactor_fully_async_agentloop
Mar 10, 2026
Merged

[fully_async, one_step_off] feat: support auto resume on abort when using fully_async#5487
wuxibin89 merged 23 commits intoverl-project:mainfrom
meituan-search:refactor_fully_async_agentloop

Conversation

@ArronHZG
Copy link
Copy Markdown
Collaborator

@ArronHZG ArronHZG commented Mar 4, 2026

What does this PR do?

Refactor the fully_async code based on #5430 to support the gateway mode, and decouple the tool invocation and rollout processes during the partial rollout phase.

Feature use_trainer_do_validate is not ready for use, I will fix it in a subsequent PR.

image

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward, fully_async, one_step_off
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant refactoring of the fully_async policy to support automatic resumption of aborted rollouts. The changes simplify the architecture by removing the explicit cancel_queue and dedicated partial agent loops, integrating the retry logic directly into the FullyAsyncLLMServerManager. This refactoring also includes better code organization by moving utility functions and enhances robustness in asynchronous task handling through the new safe_create_task utility. The review comment highlights a critical aspect of robust asynchronous task handling by recommending proper exception logging in done_callbacks, which aligns with the goal of enhancing reliability.

Comment on lines +375 to +377
except Exception as e:
print(f"Task {task.get_name()} failed with exception: {e}")
raise e
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Raising an exception from a done_callback is not recommended. The exception is not propagated to the task's creator and is instead handled by the event loop's exception handler. This can lead to ungraceful process termination or hard-to-debug silent failures. It's better to log the exception with a full traceback here. If a failure in a task should stop the entire application, it should be done via a more explicit and graceful shutdown mechanism.

Suggested change
except Exception as e:
print(f"Task {task.get_name()} failed with exception: {e}")
raise e
except Exception:
import logging
import traceback
logging.error(f"Task {task.get_name()} failed with exception:\n{traceback.format_exc()}")

@wuxibin89 wuxibin89 mentioned this pull request Mar 4, 2026
28 tasks
group_name=self.sync_group_name,
)

def sync_weights(self, version, validate=False, global_steps=0, use_trainer_do_validate=False):
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need a remote ParameterSynchronizer? Could it be absorb into FullyAsyncTrainer?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should work. The core logic has been moved over.

actor_rollout_ref.actor.entropy_coeff=0
actor_rollout_ref.actor.loss_agg_mode=${loss_agg_mode}
actor_rollout_ref.rollout.gpu_memory_utilization=0.70
actor_rollout_ref.rollout.gpu_memory_utilization=0.50
Copy link
Copy Markdown
Contributor

@Shangwei-Li Shangwei-Li Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should gpu_memory_utilization be set so low? It's preferred to set expandable memory instead of decrease gpu_memory_utilization:
export PYTORCH_NPU_ALLOC_CONF="expandable_segments:True"
+actor_rollout_ref.rollout.enable_sleep_mode=False

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for ci oom,
Maybe I can submit a separate PR next time to modify the part you mentioned.

@wuxibin89 wuxibin89 merged commit 9aaa576 into verl-project:main Mar 10, 2026
63 of 68 checks passed
@PeterSH6
Copy link
Copy Markdown
Collaborator

PeterSH6 commented Mar 10, 2026

Why changed the extra_info to extra_fields?

@ArronHZG
Copy link
Copy Markdown
Collaborator Author

Since AgentLoopOutput, AgentData, and _InternalAgentLoopOutput all use extra_fields as the variable for storing additional information, I have unified them here.

@PeterSH6

DearFishi pushed a commit to KunlunxinAD/verl that referenced this pull request Mar 20, 2026
…sing fully_async (verl-project#5487)

### What does this PR do?

Refactor the fully_async code based on
verl-project#5430 to support the gateway
mode, and decouple the tool invocation and rollout processes during the
partial rollout phase.

Feature `use_trainer_do_validate` is not ready for use, I will fix it in
a subsequent PR.

<img width="708" height="564" alt="image"
src="https://github.com/user-attachments/assets/18e282ea-a4cf-43bc-ae1f-b4108eee8dfd"
/>

### Checklist Before Starting

- [x] Search for similar PRs. Paste at least one query link here: ...
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `veomni`, `sglang`, `vllm`,
`rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`,
`deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`,
`model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data`, `cfg`, `reward`,
`fully_async`, `one_step_off`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
  - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
  - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`

### Test

> For changes that can not be tested by CI (e.g., algorithm
implementation, new model support), validate by experiment(s) and show
results like training curve plots, evaluation results, etc.

### API and Usage Example

> Demonstrate how the API changes if any, and provide usage example(s)
if possible.

```python
# Add code snippet or script demonstrating how to use this
```

### Design & Code Changes

> Demonstrate the high-level design if this PR is complex, and list the
specific changes.

### Checklist Before Submitting

> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [x] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [x] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [x] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
- [x] If your PR is related to the `recipe` submodule, please also
update the reference to the submodule commit via `git submodule update
--remote` or `cd recipe && git pull origin main`.
@ArronHZG ArronHZG deleted the refactor_fully_async_agentloop branch March 31, 2026 06:43
sijyang pushed a commit to sijyang/verl that referenced this pull request Apr 1, 2026
…sing fully_async (verl-project#5487)

### What does this PR do?

Refactor the fully_async code based on
verl-project#5430 to support the gateway
mode, and decouple the tool invocation and rollout processes during the
partial rollout phase.

Feature `use_trainer_do_validate` is not ready for use, I will fix it in
a subsequent PR.

<img width="708" height="564" alt="image"
src="https://github.com/user-attachments/assets/18e282ea-a4cf-43bc-ae1f-b4108eee8dfd"
/>

### Checklist Before Starting

- [x] Search for similar PRs. Paste at least one query link here: ...
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `veomni`, `sglang`, `vllm`,
`rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`,
`deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`,
`model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data`, `cfg`, `reward`,
`fully_async`, `one_step_off`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
  - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
  - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`

### Test

> For changes that can not be tested by CI (e.g., algorithm
implementation, new model support), validate by experiment(s) and show
results like training curve plots, evaluation results, etc.

### API and Usage Example

> Demonstrate how the API changes if any, and provide usage example(s)
if possible.

```python
# Add code snippet or script demonstrating how to use this
```

### Design & Code Changes

> Demonstrate the high-level design if this PR is complex, and list the
specific changes.

### Checklist Before Submitting

> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [x] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [x] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [x] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
- [x] If your PR is related to the `recipe` submodule, please also
update the reference to the submodule commit via `git submodule update
--remote` or `cd recipe && git pull origin main`.
DaizeDong pushed a commit to DaizeDong/verl that referenced this pull request Apr 19, 2026
…sing fully_async (verl-project#5487)

### What does this PR do?

Refactor the fully_async code based on
verl-project#5430 to support the gateway
mode, and decouple the tool invocation and rollout processes during the
partial rollout phase.

Feature `use_trainer_do_validate` is not ready for use, I will fix it in
a subsequent PR.

<img width="708" height="564" alt="image"
src="https://github.com/user-attachments/assets/18e282ea-a4cf-43bc-ae1f-b4108eee8dfd"
/>

### Checklist Before Starting

- [x] Search for similar PRs. Paste at least one query link here: ...
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `veomni`, `sglang`, `vllm`,
`rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`,
`deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`,
`model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data`, `cfg`, `reward`,
`fully_async`, `one_step_off`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
  - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
  - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`

### Test

> For changes that can not be tested by CI (e.g., algorithm
implementation, new model support), validate by experiment(s) and show
results like training curve plots, evaluation results, etc.

### API and Usage Example

> Demonstrate how the API changes if any, and provide usage example(s)
if possible.

```python
# Add code snippet or script demonstrating how to use this
```

### Design & Code Changes

> Demonstrate the high-level design if this PR is complex, and list the
specific changes.

### Checklist Before Submitting

> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [x] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [x] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [x] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
- [x] If your PR is related to the `recipe` submodule, please also
update the reference to the submodule commit via `git submodule update
--remote` or `cd recipe && git pull origin main`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants