fix: correct enable_activation_offload config parameter name#4692
Merged
vermouth1992 merged 1 commit intoverl-project:mainfrom Dec 28, 2025
Merged
Conversation
…oject#4672) The shell scripts were using `enable_activation_offloading` but the HFModelConfig field is named `enable_activation_offload` (without "ing"). This mismatch caused OmegaConf to fail with: Key 'enable_activation_offloading' not in 'HFModelConfig' Fixed files: - examples/sglang_multiturn/run_qwen2.5-0.5b_gsm8k_multiturn_w_interaction.sh - tests/special_e2e/run_gsm8k_fsdp_sgl_multiturn_sf_tool.sh Fixes verl-project#4672 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a typo in the configuration parameter name for enabling activation offloading. The parameter was changed from enable_activation_offloading to enable_activation_offload in two shell scripts, which aligns with the expected field name in HFModelConfig and resolves a ConfigKeyError. The change is accurate and well-targeted. It's worth noting the underlying inconsistency between the function name enable_activation_offloading() and the configuration key enable_activation_offload, which was the root cause of this bug. Aligning these names in a future refactoring would improve clarity and prevent similar issues. The current fix is correct and I have no further comments.
vermouth1992
approved these changes
Dec 28, 2025
boren-ms
pushed a commit
to boren-ms/verl
that referenced
this pull request
Dec 30, 2025
…oject#4692) ## Summary Fixes verl-project#4672 - The shell scripts were using `enable_activation_offloading` but the `HFModelConfig` field is named `enable_activation_offload` (without the "ing" suffix). This mismatch caused OmegaConf to fail with: ``` omegaconf.errors.ConfigKeyError: Key 'enable_activation_offloading' not in 'HFModelConfig' ``` ### Changes Fixed the parameter name in two shell scripts: - `examples/sglang_multiturn/run_qwen2.5-0.5b_gsm8k_multiturn_w_interaction.sh` - `tests/special_e2e/run_gsm8k_fsdp_sgl_multiturn_sf_tool.sh` ### Note The function that implements the feature is correctly named `enable_activation_offloading()` (with "ing"), but the config field that controls it is `enable_activation_offload` (without "ing"). The worker code correctly uses the config field name. ## Test plan - [x] Verified HFModelConfig has `enable_activation_offload` field (line 73 of `verl/workers/config/model.py`) - [ ] Run the example script to verify it works 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: yurekami <yurekami@users.noreply.github.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
jsfanfanfan
pushed a commit
to meituan-search/verl
that referenced
this pull request
Jan 9, 2026
…oject#4692) ## Summary Fixes verl-project#4672 - The shell scripts were using `enable_activation_offloading` but the `HFModelConfig` field is named `enable_activation_offload` (without the "ing" suffix). This mismatch caused OmegaConf to fail with: ``` omegaconf.errors.ConfigKeyError: Key 'enable_activation_offloading' not in 'HFModelConfig' ``` ### Changes Fixed the parameter name in two shell scripts: - `examples/sglang_multiturn/run_qwen2.5-0.5b_gsm8k_multiturn_w_interaction.sh` - `tests/special_e2e/run_gsm8k_fsdp_sgl_multiturn_sf_tool.sh` ### Note The function that implements the feature is correctly named `enable_activation_offloading()` (with "ing"), but the config field that controls it is `enable_activation_offload` (without "ing"). The worker code correctly uses the config field name. ## Test plan - [x] Verified HFModelConfig has `enable_activation_offload` field (line 73 of `verl/workers/config/model.py`) - [ ] Run the example script to verify it works 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: yurekami <yurekami@users.noreply.github.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
vyomakesh0728
added a commit
to vyomakesh0728/verl
that referenced
this pull request
Jan 22, 2026
…oject#4692) ## Summary Fixes verl-project#4672 - The shell scripts were using `enable_activation_offloading` but the `HFModelConfig` field is named `enable_activation_offload` (without the "ing" suffix). This mismatch caused OmegaConf to fail with: ``` omegaconf.errors.ConfigKeyError: Key 'enable_activation_offloading' not in 'HFModelConfig' ``` ### Changes Fixed the parameter name in two shell scripts: - `examples/sglang_multiturn/run_qwen2.5-0.5b_gsm8k_multiturn_w_interaction.sh` - `tests/special_e2e/run_gsm8k_fsdp_sgl_multiturn_sf_tool.sh` ### Note The function that implements the feature is correctly named `enable_activation_offloading()` (with "ing"), but the config field that controls it is `enable_activation_offload` (without "ing"). The worker code correctly uses the config field name. ## Test plan - [x] Verified HFModelConfig has `enable_activation_offload` field (line 73 of `verl/workers/config/model.py`) - [ ] Run the example script to verify it works 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: yurekami <yurekami@users.noreply.github.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
sophiayyya
pushed a commit
to sophiayyya/verl
that referenced
this pull request
Jan 25, 2026
…oject#4692) ## Summary Fixes verl-project#4672 - The shell scripts were using `enable_activation_offloading` but the `HFModelConfig` field is named `enable_activation_offload` (without the "ing" suffix). This mismatch caused OmegaConf to fail with: ``` omegaconf.errors.ConfigKeyError: Key 'enable_activation_offloading' not in 'HFModelConfig' ``` ### Changes Fixed the parameter name in two shell scripts: - `examples/sglang_multiturn/run_qwen2.5-0.5b_gsm8k_multiturn_w_interaction.sh` - `tests/special_e2e/run_gsm8k_fsdp_sgl_multiturn_sf_tool.sh` ### Note The function that implements the feature is correctly named `enable_activation_offloading()` (with "ing"), but the config field that controls it is `enable_activation_offload` (without "ing"). The worker code correctly uses the config field name. ## Test plan - [x] Verified HFModelConfig has `enable_activation_offload` field (line 73 of `verl/workers/config/model.py`) - [ ] Run the example script to verify it works 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: yurekami <yurekami@users.noreply.github.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4672 - The shell scripts were using
enable_activation_offloadingbut theHFModelConfigfield is namedenable_activation_offload(without the "ing" suffix).This mismatch caused OmegaConf to fail with:
Changes
Fixed the parameter name in two shell scripts:
examples/sglang_multiturn/run_qwen2.5-0.5b_gsm8k_multiturn_w_interaction.shtests/special_e2e/run_gsm8k_fsdp_sgl_multiturn_sf_tool.shNote
The function that implements the feature is correctly named
enable_activation_offloading()(with "ing"), but the config field that controls it isenable_activation_offload(without "ing"). The worker code correctly uses the config field name.