Skip to content

[ci] fix: fix config#4685

Merged
PeterSH6 merged 1 commit intoverl-project:mainfrom
vermouth1992:chi/fix/doc
Dec 27, 2025
Merged

[ci] fix: fix config#4685
PeterSH6 merged 1 commit intoverl-project:mainfrom
vermouth1992:chi/fix/doc

Conversation

@vermouth1992
Copy link
Collaborator

What does this PR do?

  • As title

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes the configuration for tau_pos and tau_neg to align with the project's YAML style guide by separating them. My review includes a suggestion to improve the new comment for tau_neg for better clarity and consistency, and also points out a related inconsistency in the comment for tau_pos that was introduced by this change.

Comment on lines +48 to 49
# negative tau for smoothing function in SAPO
tau_neg: 1.05
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Thanks for adding the comment and blank line to follow the file's style guide. The new comment for tau_neg is a bit sparse. It would be better to include the paper reference to be consistent with other parameters.

Also, a heads-up: the comment for tau_pos on lines 44-45 is now slightly misleading as it still mentions 'Positive and negative tau'. It would be great if you could update that as well to only refer to 'Positive tau' to avoid confusion.

Here's a suggestion for tau_neg:

# Negative tau for smoothing function in SAPO (https://arxiv.org/pdf/2511.20347)
tau_neg: 1.05

@PeterSH6 PeterSH6 merged commit b532875 into verl-project:main Dec 27, 2025
7 checks passed
boren-ms pushed a commit to boren-ms/verl that referenced this pull request Dec 30, 2025
jsfanfanfan pushed a commit to meituan-search/verl that referenced this pull request Jan 9, 2026
vyomakesh0728 added a commit to vyomakesh0728/verl that referenced this pull request Jan 22, 2026
sophiayyya pushed a commit to sophiayyya/verl that referenced this pull request Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants