-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[rollout, trainer] feat: extend agent loop for custom implementations #4548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8775425
feat: support configurable AgentLoopManager via config
JoyboyBrian e3dc8e8
feat(rollout): add optional tool_calls field to TokenOutput model
JoyboyBrian 4b62ab5
feat(rollout): add support for custom AgentLoopManager class
JoyboyBrian 3b00d00
feat(rollout): add custom configuration support in RolloutConfig
JoyboyBrian 85f1d62
fix(trainer): replace exec with importlib for dynamic loading of Agen…
JoyboyBrian 8560165
refactor(agent_loop): extract tokenization utilities for reusability
JoyboyBrian e77999b
simplify custom configuration documentation
JoyboyBrian 58315a2
remove comments
JoyboyBrian b879412
remove redundant import statement for importlib
JoyboyBrian 687fb36
refactor: move tokenization utils to chat_template.py and remove dupl…
JoyboyBrian 7c26cac
refactor: reorganize imports and enhance chat template utilities
JoyboyBrian 9039efe
delete unused fields
JoyboyBrian 2b08e0c
refactor: update apply_chat_template_kwargs handling in chat template…
JoyboyBrian c8a4b99
refactor(trainer): enhance error handling for custom AgentLoopManager…
JoyboyBrian 3b78336
refactor(trainer): streamline AgentLoopManager loading with utility f…
JoyboyBrian 36c1d5c
refactor(agent_loop): streamline chat template processing in ToolAgen…
JoyboyBrian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field seems not used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field is designed as an extension point for downstream projects to pass custom configurations without modifying core config classes.
For example, a project implementing remote rollout could use:
Then access it via
config.actor_rollout_ref.rollout.get("custom", {})in their custom AgentLoopManager.Happy to add a docstring clarifying this is an extension point!