Skip to content

[sglang, rollout] feat: delete remaining sglang spmd code#4523

Merged
vermouth1992 merged 1 commit intoverl-project:mainfrom
PeterSH6:gm/delet_sglang
Dec 15, 2025
Merged

[sglang, rollout] feat: delete remaining sglang spmd code#4523
vermouth1992 merged 1 commit intoverl-project:mainfrom
PeterSH6:gm/delet_sglang

Conversation

@PeterSH6
Copy link
Collaborator

What does this PR do?

As titled

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes two files, verl/third_party/sglang/__init__.py and verl/third_party/sglang/parallel_state.py, to clean up what appears to be obsolete SPMD-related code for sglang. This is a straightforward code cleanup. After reviewing the provided repository context, I found no active usages of the deleted parallel_state.py module, which suggests this removal is safe and correct. The change is a good step towards simplifying the codebase.

@vermouth1992 vermouth1992 merged commit 5922445 into verl-project:main Dec 15, 2025
81 of 94 checks passed
vyomakesh0728 added a commit to vyomakesh0728/verl that referenced this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants