Revert "[worker] feat: add support for colocate replicas"#4259
Merged
vermouth1992 merged 1 commit intomainfrom Nov 24, 2025
Merged
Revert "[worker] feat: add support for colocate replicas"#4259vermouth1992 merged 1 commit intomainfrom
vermouth1992 merged 1 commit intomainfrom
Conversation
This reverts commit 9c5facb.
wuxibin89
requested review from
PeterSH6,
SwordFaith,
chenhaiq,
eric-haibin-lin,
tongyx361,
vermouth1992 and
zhaochenyang20
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reverts the feature 'add support for colocate replicas'. The changes correctly remove the logic related to collocated worker groups for reward models and restore the previous implementation that uses resource pools. The associated test file for the feature has also been removed. The revert appears to be complete and correct based on the provided changes. I have not identified any issues with this revert.
vermouth1992
approved these changes
Nov 24, 2025
Di-viner
pushed a commit
to Di-viner/verl
that referenced
this pull request
Nov 30, 2025
TimurTaepov
pushed a commit
to giorgossideris/verl
that referenced
this pull request
Dec 20, 2025
vyomakesh0728
added a commit
to vyomakesh0728/verl
that referenced
this pull request
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4233