[trainer] fix: Ref to #3596. More import fix for transformers version higher than 4.55.0 by A1waysBeenHere · Pull Request #3608 · verl-project/verl

A1waysBeenHere · 2025-09-25T03:24:38Z

What does this PR do?

Ref to #3596, more import fix for transformers version higher than 4.55.0

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Checklist Before Starting

Search for similar PRs. Paste at least one query link here: ...
Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
- {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
- If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
- {type} is in feat, fix, refactor, chore, test
- If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
- Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Read the Contribute Guide.
Apply pre-commit checks: pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always
Add / Update the documentation.
Add unit or end-to-end test(s) to the CI workflow to cover all the code. If not feasible, explain why: ...
Once your PR is ready for CI, send a message in the ci-request channel in the verl Slack workspace. (If not accessible, please try the Feishu group (飞书群).)

CLAassistant · 2025-09-25T03:24:44Z

All committers have signed the CLA.

gemini-code-assist

Code Review

This pull request addresses an import issue for transformers versions higher than 4.55.0 by adding a try-except block to handle module path changes for NPU flash attention utilities. The fix itself seems correct and handles backward compatibility. However, the compatibility logic is duplicated across three different files. My main feedback is to refactor this duplicated code into a single, shared utility module to improve maintainability and adhere to the DRY principle. This will make future updates to this logic much easier and less error-prone.

ji-huazhong · 2025-09-25T08:56:44Z

+        if hasattr(torch, "npu") and callable(getattr(torch.npu, "is_available", None)):
+            return torch.npu.is_available()
+        return False


I like this modification :)

ji-huazhong · 2025-09-25T09:07:04Z

 from transformers import AutoConfig, AutoModelForCausalLM, PreTrainedModel

 import verl.utils.hdfs_io as hdfs_io
+from verl.utils.attention_imports import index_first_axis, pad_input, rearrange, unpad_input


It might be more appropriate to rename it to attention_utils

It might be more appropriate to rename it to attention_utils

done

…put to pass the check_api_docs CI checking

…mers version higher than 4.55.0 (verl-project#3608) ### What does this PR do? Ref to verl-project#3596, more import fix for transformers version higher than 4.55.0 > Add **concise** overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review. ### Checklist Before Starting - [x] Search for similar PRs. Paste at least one query link here: ... - [x] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [x] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [ ] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)

A1waysBeenHere requested review from PeterSH6, ZihengJiang, eric-haibin-lin, tongyx361 and vermouth1992 as code owners September 25, 2025 03:24

gemini-code-assist Bot reviewed Sep 25, 2025

View reviewed changes

Comment thread verl/trainer/fsdp_sft_trainer.py Outdated

Comment thread verl/workers/critic/dp_critic.py Outdated

Comment thread verl/workers/engine/fsdp/transformer_impl.py Outdated

A1waysBeenHere changed the title ~~[trainer] fix: Ref to #3595. More import fix for transformers version higher than 4.55.0~~ [trainer] fix: Ref to #3596. More import fix for transformers version higher than 4.55.0 Sep 25, 2025

A1waysBeenHere force-pushed the main branch 2 times, most recently from 774a99e to 08f168f Compare September 25, 2025 03:31

A1waysBeenHere requested a review from zhaochenyang20 as a code owner September 25, 2025 03:55

vermouth1992 reviewed Sep 25, 2025

View reviewed changes

Comment thread tests/models/test_transformer.py Outdated

A1waysBeenHere force-pushed the main branch from 49275b6 to 08f168f Compare September 25, 2025 06:30

ji-huazhong approved these changes Sep 25, 2025

View reviewed changes

A1waysBeenHere force-pushed the main branch from 08f168f to c5b420e Compare September 25, 2025 08:47

Moved all import logic to 'verl/utils/attention_imports.py'

b081b9f

A1waysBeenHere force-pushed the main branch from c5b420e to b081b9f Compare September 25, 2025 08:49

Removed redundant code

d52146b

ji-huazhong reviewed Sep 25, 2025

View reviewed changes

A1waysBeenHere force-pushed the main branch 6 times, most recently from 18ee773 to 024476c Compare September 25, 2025 12:18

FightingZhen approved these changes Sep 25, 2025

View reviewed changes

A1waysBeenHere force-pushed the main branch from 024476c to 0fe6a95 Compare September 26, 2025 02:38

Renamed attention_import.py to attention_utils.py

95b582f

A1waysBeenHere force-pushed the main branch from 0fe6a95 to 95b582f Compare September 26, 2025 03:07

Added docstrings for index_first_axis, pad_input, rearrange, unpad_in…

3ffb4e6

…put to pass the check_api_docs CI checking

A1waysBeenHere requested a review from vermouth1992 September 26, 2025 09:48

wuxibin89 merged commit 64a9860 into verl-project:main Sep 26, 2025
65 of 66 checks passed

wuxibin89 mentioned this pull request Sep 28, 2025

[sglang] feat: adapt for sglang+verl #3506

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[trainer] fix: Ref to #3596. More import fix for transformers version higher than 4.55.0#3608

[trainer] fix: Ref to #3596. More import fix for transformers version higher than 4.55.0#3608
wuxibin89 merged 4 commits into
verl-project:mainfrom
A1waysBeenHere:main

A1waysBeenHere commented Sep 25, 2025 •

edited

Loading

Uh oh!

CLAassistant commented Sep 25, 2025 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ji-huazhong Sep 25, 2025

Uh oh!

ji-huazhong Sep 25, 2025

Uh oh!

A1waysBeenHere Sep 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

A1waysBeenHere commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Checklist Before Starting

Test

API and Usage Example

Design & Code Changes

Checklist Before Submitting

Uh oh!

CLAassistant commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ji-huazhong Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

ji-huazhong Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

A1waysBeenHere Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

A1waysBeenHere commented Sep 25, 2025 •

edited

Loading

CLAassistant commented Sep 25, 2025 •

edited

Loading