[data] fix: update parquet_files type check to support multi-file input#3211
Merged
vermouth1992 merged 1 commit intoverl-project:mainfrom Aug 25, 2025
Merged
[data] fix: update parquet_files type check to support multi-file input#3211vermouth1992 merged 1 commit intoverl-project:mainfrom
vermouth1992 merged 1 commit intoverl-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a type-checking issue in MultiTurnSFTDataset by updating the condition to correctly handle omegaconf.ListConfig inputs for parquet_files. This prevents incorrect list nesting and ensures that multiple file paths provided via configuration are processed correctly. The change is a good improvement. I've added one high-severity comment regarding an unhandled edge case that could lead to a crash.
vermouth1992
approved these changes
Aug 25, 2025
PopSoda2002
pushed a commit
to PopSoda2002/verl
that referenced
this pull request
Aug 26, 2025
yellowbee686
pushed a commit
to yellowbee686/verl
that referenced
this pull request
Aug 27, 2025
cczitong123
pushed a commit
to cczitong123/verl
that referenced
this pull request
Sep 5, 2025
DDVD233
pushed a commit
to DDVD233/mirl
that referenced
this pull request
Sep 5, 2025
WncFht
pushed a commit
to WncFht/verl
that referenced
this pull request
Oct 10, 2025
techkang
pushed a commit
to techkang/verl
that referenced
this pull request
Oct 31, 2025
chenjiaoAngel
added a commit
to chenjiaoAngel/verl
that referenced
this pull request
Nov 14, 2025
TimurTaepov
pushed a commit
to giorgossideris/verl
that referenced
this pull request
Dec 20, 2025
vyomakesh0728
added a commit
to vyomakesh0728/verl
that referenced
this pull request
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingAPI and Usage Example
When using xargs to perform SFT training on multiple datasets, the command is:
torchrun --nnodes=1 --nproc_per_node=8 -m verl.trainer.fsdp_sft_trainer \ data.train_files=["data_path_1","data_path_2"] \ ...The existing code checks whether the input is a list, but the actual parsed result is a
ListConfig, causing an extra level of nesting and leading to an error.Therefore, the condition is updated to
isinstance(parquet_files, list | ListConfig).Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)