Skip to content

[docker] feat: update to vllm 0.10.0, mcore 0.13, transformers 4.55.4#3192

Merged
vermouth1992 merged 42 commits intoverl-project:mainfrom
ETOgaosion:update_mcore_0.13
Aug 25, 2025
Merged

[docker] feat: update to vllm 0.10.0, mcore 0.13, transformers 4.55.4#3192
vermouth1992 merged 42 commits intoverl-project:mainfrom
ETOgaosion:update_mcore_0.13

Conversation

@ETOgaosion
Copy link
Collaborator

What does this PR do?

[docker] feat: update to vllm 0.10.0, mcore 0.13, transformers 4.55.4

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several key dependencies, including vLLM to 0.10.0, Megatron-Core to 0.13, and Transformers to 4.55.4. The changes primarily involve updating version numbers in Dockerfiles and documentation, and adapting the code to the new APIs of these libraries.

My review found one high-severity issue in the monkey-patching logic for vision models. The current patch for transformers>=4.55.0 is likely ineffective, necessitating a performance-degrading workaround that disables flash attention for vision models when using Ulysses sequence parallelism. I've suggested a more robust patching strategy that should fix the underlying issue and allow for the removal of the workaround.

Other changes appear to be correct and consistent with the goal of updating dependencies.

return attn_output


def _ulysses_flash_attention_forward_new_api(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify the name to _ulysses_flash_attention_forward_transformers_4_55

max_model_len=self.max_model_len,
max_num_seqs=config.max_num_seqs,
load_format=config.load_format,
load_format="dummy" if self.config.load_format.startswith("dummy") else self.config.load_format,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vermouth1992 I fix vllm as sglang's way of load_format setting.

@vermouth1992 vermouth1992 merged commit 9b6a07f into verl-project:main Aug 25, 2025
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants