[DataProto] Supporting new operations for DataProto#1761
Merged
eric-haibin-lin merged 4 commits intoverl-project:mainfrom May 30, 2025
Merged
[DataProto] Supporting new operations for DataProto#1761eric-haibin-lin merged 4 commits intoverl-project:mainfrom
DataProto#1761eric-haibin-lin merged 4 commits intoverl-project:mainfrom
Conversation
Signed-off-by: Hongpeng Guo <hg5@illinois.edu>
Signed-off-by: Hongpeng Guo <hg5@illinois.edu>
Signed-off-by: Hongpeng Guo <hg5@illinois.edu>
Collaborator
|
some broken megatron-sglang tests will be fixed by #1717 |
eric-haibin-lin
approved these changes
May 30, 2025
yzlnew
pushed a commit
to yzlnew/verl
that referenced
this pull request
Jun 4, 2025
…old_column_chunks) for `DataProto` (verl-project#1761) ### Checklist Before Starting - [x] Search for similar PR(s). ### What does this PR do? Adding/ Enriching new operations on `DataProto` data class: 1. Making `DataProto` compitable with `self.batch is None`, this is useful when we are using a `DataProto` to contain non-tensor data only, i.e., images for vlm use cases; 2. `sample_level_repeat`： this function repeat the rows in DataProto multiple times in sample level; 3. `unfold_column_chunks`: this function split along the second dim into `n_splits` folds. Useful in passing grouped tensors that doesn't want to be shuffled in dataset. ### API & Test Please check the usage from the added unit test files: `tests/test_protocol.py`. There are three unit tests added, which are: `test_dataproto_no_batch`, `test_sample_level_repeat`, and `test_dataproto_unfold_column_chunks`. ### Checklist Before Submitting - [x] Read the [Contribute Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting). - [ ] Add `[BREAKING]` to the PR title if it breaks any API. - [ ] Update the documentation about your changes in the [docs](https://github.com/volcengine/verl/tree/main/docs). - [x] Add CI test(s) if necessary. --------- Signed-off-by: Hongpeng Guo <hg5@illinois.edu>
wwwjn
pushed a commit
to wwwjn/verl
that referenced
this pull request
Jun 10, 2025
…old_column_chunks) for `DataProto` (verl-project#1761) ### Checklist Before Starting - [x] Search for similar PR(s). ### What does this PR do? Adding/ Enriching new operations on `DataProto` data class: 1. Making `DataProto` compitable with `self.batch is None`, this is useful when we are using a `DataProto` to contain non-tensor data only, i.e., images for vlm use cases; 2. `sample_level_repeat`： this function repeat the rows in DataProto multiple times in sample level; 3. `unfold_column_chunks`: this function split along the second dim into `n_splits` folds. Useful in passing grouped tensors that doesn't want to be shuffled in dataset. ### API & Test Please check the usage from the added unit test files: `tests/test_protocol.py`. There are three unit tests added, which are: `test_dataproto_no_batch`, `test_sample_level_repeat`, and `test_dataproto_unfold_column_chunks`. ### Checklist Before Submitting - [x] Read the [Contribute Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting). - [ ] Add `[BREAKING]` to the PR title if it breaks any API. - [ ] Update the documentation about your changes in the [docs](https://github.com/volcengine/verl/tree/main/docs). - [x] Add CI test(s) if necessary. --------- Signed-off-by: Hongpeng Guo <hg5@illinois.edu>
chenjiaoAngel
added a commit
to chenjiaoAngel/verl
that referenced
this pull request
Nov 14, 2025
…old_column_chunks) for `DataProto` (verl-project#1761) ### Checklist Before Starting - [x] Search for similar PR(s). ### What does this PR do? Adding/ Enriching new operations on `DataProto` data class: 1. Making `DataProto` compitable with `self.batch is None`, this is useful when we are using a `DataProto` to contain non-tensor data only, i.e., images for vlm use cases; 2. `sample_level_repeat`： this function repeat the rows in DataProto multiple times in sample level; 3. `unfold_column_chunks`: this function split along the second dim into `n_splits` folds. Useful in passing grouped tensors that doesn't want to be shuffled in dataset. ### API & Test Please check the usage from the added unit test files: `tests/test_protocol.py`. There are three unit tests added, which are: `test_dataproto_no_batch`, `test_sample_level_repeat`, and `test_dataproto_unfold_column_chunks`. ### Checklist Before Submitting - [x] Read the [Contribute Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting). - [ ] Add `[BREAKING]` to the PR title if it breaks any API. - [ ] Update the documentation about your changes in the [docs](https://github.com/volcengine/verl/tree/main/docs). - [x] Add CI test(s) if necessary. --------- Signed-off-by: Hongpeng Guo <hg5@illinois.edu>
TimurTaepov
pushed a commit
to giorgossideris/verl
that referenced
this pull request
Dec 20, 2025
…old_column_chunks) for `DataProto` (verl-project#1761) ### Checklist Before Starting - [x] Search for similar PR(s). ### What does this PR do? Adding/ Enriching new operations on `DataProto` data class: 1. Making `DataProto` compitable with `self.batch is None`, this is useful when we are using a `DataProto` to contain non-tensor data only, i.e., images for vlm use cases; 2. `sample_level_repeat`： this function repeat the rows in DataProto multiple times in sample level; 3. `unfold_column_chunks`: this function split along the second dim into `n_splits` folds. Useful in passing grouped tensors that doesn't want to be shuffled in dataset. ### API & Test Please check the usage from the added unit test files: `tests/test_protocol.py`. There are three unit tests added, which are: `test_dataproto_no_batch`, `test_sample_level_repeat`, and `test_dataproto_unfold_column_chunks`. ### Checklist Before Submitting - [x] Read the [Contribute Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting). - [ ] Add `[BREAKING]` to the PR title if it breaks any API. - [ ] Update the documentation about your changes in the [docs](https://github.com/volcengine/verl/tree/main/docs). - [x] Add CI test(s) if necessary. --------- Signed-off-by: Hongpeng Guo <hg5@illinois.edu>
vyomakesh0728
added a commit
to vyomakesh0728/verl
that referenced
this pull request
Jan 22, 2026
…old_column_chunks) for `DataProto` (verl-project#1761) ### Checklist Before Starting - [x] Search for similar PR(s). ### What does this PR do? Adding/ Enriching new operations on `DataProto` data class: 1. Making `DataProto` compitable with `self.batch is None`, this is useful when we are using a `DataProto` to contain non-tensor data only, i.e., images for vlm use cases; 2. `sample_level_repeat`： this function repeat the rows in DataProto multiple times in sample level; 3. `unfold_column_chunks`: this function split along the second dim into `n_splits` folds. Useful in passing grouped tensors that doesn't want to be shuffled in dataset. ### API & Test Please check the usage from the added unit test files: `tests/test_protocol.py`. There are three unit tests added, which are: `test_dataproto_no_batch`, `test_sample_level_repeat`, and `test_dataproto_unfold_column_chunks`. ### Checklist Before Submitting - [x] Read the [Contribute Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting). - [ ] Add `[BREAKING]` to the PR title if it breaks any API. - [ ] Update the documentation about your changes in the [docs](https://github.com/volcengine/verl/tree/main/docs). - [x] Add CI test(s) if necessary. --------- Signed-off-by: Hongpeng Guo <hg5@illinois.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist Before Starting
What does this PR do?
Adding/ Enriching new operations on
DataProtodata class:DataProtocompitable withself.batch is None, this is useful when we are using aDataPrototo contain non-tensor data only, i.e., images for vlm use cases;sample_level_repeat： this function repeat the rows in DataProto multiple times in sample level;unfold_column_chunks: this function split along the second dim inton_splitsfolds. Useful in passing grouped tensors that doesn't want to be shuffled in dataset.API & Test
Please check the usage from the added unit test files:
tests/test_protocol.py. There are three unit tests added, which are:test_dataproto_no_batch,test_sample_level_repeat, andtest_dataproto_unfold_column_chunks.Checklist Before Submitting
[BREAKING]to the PR title if it breaks any API.