[fix] adding temperature only when fused kernels are used#1688
Closed
mingruimingrui wants to merge 1 commit intoverl-project:mainfrom
Closed
[fix] adding temperature only when fused kernels are used#1688mingruimingrui wants to merge 1 commit intoverl-project:mainfrom
mingruimingrui wants to merge 1 commit intoverl-project:mainfrom
Conversation
Collaborator
|
duplicated of #1687 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist Before Starting
What does this PR do?
Temperature was automatically added to dp_actor
model.forward, however this breaks under some transformers version.This PR only adds temperature to model.forward when fused_kernels patch is used.
High-Level Design
Specific Changes
API
Usage Example
Test
Additional Info.
Checklist Before Submitting
[BREAKING]to the PR title if it breaks any API.