Skip to content

[tests] BREAKING: move recipe.dapo.src to recipe.dapo; move test files to their own namespaces (tests/verl/xxx -> tests/xxx)#1392

Merged
vermouth1992 merged 9 commits intoverl-project:mainfrom
eric-haibin-lin:hlin/tests
May 10, 2025
Merged

Conversation

@eric-haibin-lin
Copy link
Collaborator

@eric-haibin-lin eric-haibin-lin commented May 4, 2025

Checklist Before Starting

  • Search for similar PR(s).

What does this PR do?

Reorganize file structure:

  • recipe.dapo.src -> recipe.dapo
  • tests/verl/xxx -> tests/xxx. There are a few other folders need to be renamed later (e.g. ray tests)

High-Level Design

None

Specific Changes

See changed files

API

For anyone who uses recipe.dapo.src, please change to recipe.dapo instead (although anything under recipe is not provided as APIs from verl).

Usage Example

None

Test

Reusing existing tests.

Additional Info.

  • Issue Number: Fixes issue # or discussion # if any.
  • Training: [Note which backend this PR will affect: FSDP, Megatron, both, or none]
  • Inference: [Note which backend this PR will affect: vLLM, SGLang, both, or none]

Checklist Before Submitting

  • Read the Contribute Guide.
  • Apply pre-commit checks.
  • Add [BREAKING] to the PR title if it breaks any API.
  • Update the documentation about your changes in the docs.
  • Add CI test(s) if neccessary.

tongyx361
tongyx361 previously approved these changes May 5, 2025
View reviewed changes
@vermouth1992 vermouth1992 enabled auto-merge (squash) May 10, 2025 03:21
@vermouth1992 vermouth1992 merged commit 249c26f into verl-project:main May 10, 2025
29 checks passed
@tongyx361 tongyx361 mentioned this pull request May 24, 2025
Merged
7 tasks
ETOgaosion pushed a commit that referenced this pull request May 24, 2025
@tongyx361
[CI] fix: DAPO CI & response_mask (#1666)
5dc6439 
### Checklist Before Starting

- [x] Search for similar PR(s).

### What does this PR do?

This PR fixes:

- DAPO CI triggering path patterns outdated since #1392
- `response_mask` computation missing but skipping the CI test in #1652 

### Tests

- [x] DAPO CI is correctly triggered and passed, e.g.,
https://github.com/volcengine/verl/actions/runs/15223958183/job/42823610223?pr=1666

### Additional Info.

- **Issue Number**: #1392 , #1652 
- **Training**: none
- **Inference**: none

### Checklist Before Submitting

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting).
- [x] Add `[BREAKING]` to the PR title if it breaks any API.
- [x] Update the documentation about your changes in the
[docs](https://github.com/volcengine/verl/tree/main/docs).
- [x] Add CI test(s) if necessary.
ETOgaosion pushed a commit to Jianbing-D/verl that referenced this pull request Jun 8, 2025
@tongyx361 @ETOgaosion
[CI] fix: DAPO CI & response_mask (verl-project#1666)
7583479 
### Checklist Before Starting

- [x] Search for similar PR(s).

### What does this PR do?

This PR fixes:

- DAPO CI triggering path patterns outdated since verl-project#1392
- `response_mask` computation missing but skipping the CI test in verl-project#1652 

### Tests

- [x] DAPO CI is correctly triggered and passed, e.g.,
https://github.com/volcengine/verl/actions/runs/15223958183/job/42823610223?pr=1666

### Additional Info.

- **Issue Number**: verl-project#1392 , verl-project#1652 
- **Training**: none
- **Inference**: none

### Checklist Before Submitting

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting).
- [x] Add `[BREAKING]` to the PR title if it breaks any API.
- [x] Update the documentation about your changes in the
[docs](https://github.com/volcengine/verl/tree/main/docs).
- [x] Add CI test(s) if necessary.
wwwjn pushed a commit to wwwjn/verl that referenced this pull request Jun 10, 2025
@tongyx361 @wwwjn
[CI] fix: DAPO CI & response_mask (verl-project#1666)
89fa6b5 
### Checklist Before Starting

- [x] Search for similar PR(s).

### What does this PR do?

This PR fixes:

- DAPO CI triggering path patterns outdated since verl-project#1392
- `response_mask` computation missing but skipping the CI test in verl-project#1652 

### Tests

- [x] DAPO CI is correctly triggered and passed, e.g.,
https://github.com/volcengine/verl/actions/runs/15223958183/job/42823610223?pr=1666

### Additional Info.

- **Issue Number**: verl-project#1392 , verl-project#1652 
- **Training**: none
- **Inference**: none

### Checklist Before Submitting

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting).
- [x] Add `[BREAKING]` to the PR title if it breaks any API.
- [x] Update the documentation about your changes in the
[docs](https://github.com/volcengine/verl/tree/main/docs).
- [x] Add CI test(s) if necessary.
chenjiaoAngel added a commit to chenjiaoAngel/verl that referenced this pull request Nov 14, 2025
@chenjiaoAngel
[tests] BREAKING: move recipe.dapo.src to recipe.dapo; move test file…
8526bc3 
…s to their own namespaces (tests/verl/xxx -> tests/xxx) (verl-project#1392)
chenjiaoAngel added a commit to chenjiaoAngel/verl that referenced this pull request Nov 14, 2025
@chenjiaoAngel
[CI] fix: DAPO CI & response_mask (verl-project#1666)
326c349 
### Checklist Before Starting

- [x] Search for similar PR(s).

### What does this PR do?

This PR fixes:

- DAPO CI triggering path patterns outdated since verl-project#1392
- `response_mask` computation missing but skipping the CI test in verl-project#1652 

### Tests

- [x] DAPO CI is correctly triggered and passed, e.g.,
https://github.com/volcengine/verl/actions/runs/15223958183/job/42823610223?pr=1666

### Additional Info.

- **Issue Number**: verl-project#1392 , verl-project#1652 
- **Training**: none
- **Inference**: none

### Checklist Before Submitting

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting).
- [x] Add `[BREAKING]` to the PR title if it breaks any API.
- [x] Update the documentation about your changes in the
[docs](https://github.com/volcengine/verl/tree/main/docs).
- [x] Add CI test(s) if necessary.
TimurTaepov pushed a commit to giorgossideris/verl that referenced this pull request Dec 20, 2025
@eric-haibin-lin
[tests] BREAKING: move recipe.dapo.src to recipe.dapo; move test file…
90d35ef 
…s to their own namespaces (tests/verl/xxx -> tests/xxx) (verl-project#1392)
TimurTaepov pushed a commit to giorgossideris/verl that referenced this pull request Dec 20, 2025
@tongyx361
[CI] fix: DAPO CI & response_mask (verl-project#1666)
2081433 
### Checklist Before Starting

- [x] Search for similar PR(s).

### What does this PR do?

This PR fixes:

- DAPO CI triggering path patterns outdated since verl-project#1392
- `response_mask` computation missing but skipping the CI test in verl-project#1652 

### Tests

- [x] DAPO CI is correctly triggered and passed, e.g.,
https://github.com/volcengine/verl/actions/runs/15223958183/job/42823610223?pr=1666

### Additional Info.

- **Issue Number**: verl-project#1392 , verl-project#1652 
- **Training**: none
- **Inference**: none

### Checklist Before Submitting

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting).
- [x] Add `[BREAKING]` to the PR title if it breaks any API.
- [x] Update the documentation about your changes in the
[docs](https://github.com/volcengine/verl/tree/main/docs).
- [x] Add CI test(s) if necessary.
vyomakesh0728 added a commit to vyomakesh0728/verl that referenced this pull request Jan 22, 2026
@vyomakesh0728
[tests] BREAKING: move recipe.dapo.src to recipe.dapo; move test file…
56fe008 
…s to their own namespaces (tests/verl/xxx -> tests/xxx) (verl-project#1392)
vyomakesh0728 added a commit to vyomakesh0728/verl that referenced this pull request Jan 22, 2026
@vyomakesh0728
[CI] fix: DAPO CI & response_mask (verl-project#1666)
b0d36b9 
### Checklist Before Starting

- [x] Search for similar PR(s).

### What does this PR do?

This PR fixes:

- DAPO CI triggering path patterns outdated since verl-project#1392
- `response_mask` computation missing but skipping the CI test in verl-project#1652 

### Tests

- [x] DAPO CI is correctly triggered and passed, e.g.,
https://github.com/volcengine/verl/actions/runs/15223958183/job/42823610223?pr=1666

### Additional Info.

- **Issue Number**: verl-project#1392 , verl-project#1652 
- **Training**: none
- **Inference**: none

### Checklist Before Submitting

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting).
- [x] Add `[BREAKING]` to the PR title if it breaks any API.
- [x] Update the documentation about your changes in the
[docs](https://github.com/volcengine/verl/tree/main/docs).
- [x] Add CI test(s) if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vermouth1992 vermouth1992 vermouth1992 approved these changes

@tongyx361 tongyx361 tongyx361 left review comments

Assignees

No one assigned

Labels

status: accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eric-haibin-lin @vermouth1992 @tongyx361 @ZihengJiang